pgsql: Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.

Started by Tom Lanealmost 9 years ago3 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.

Per buildfarm.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1ae8536545b7ea486dbe15247e6dd817ee211297

Modified Files
--------------
src/bin/pg_ctl/pg_ctl.c | 4 ++++
src/tools/msvc/Mkvcbuild.pm | 2 +-
2 files changed, 5 insertions(+), 1 deletion(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#1)
Re: pgsql: Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.

On 06/28/2017 06:00 PM, Tom Lane wrote:

Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.

Per buildfarm.

Looks to me like we need to put back the Makefile line for WIN32 for
pg_ctl, too.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Dunstan (#2)
Re: pgsql: Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:

On 06/28/2017 06:00 PM, Tom Lane wrote:

Ooops, WIN32 code in pg_ctl.c still needs PQExpBuffer.

Looks to me like we need to put back the Makefile line for WIN32 for
pg_ctl, too.

Oh, yuck. Forgot about mingw builds. Will fix.

regards, tom lane

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers