pgsql: Don't try to test files named with a trailing dot on Windows
Don't try to test files named with a trailing dot on Windows
The pg_verify_checksums test tries to create files with corrupt data
named "123." and "123_." But on Windows a file name with a trailing dot
is the same as a file without the trailing dot. In the first case this
will create a file with a "valid" name, which causes the test to fail in
an unexpected way, and in the secongd case this will be redandant as the
test already creates a file named "123_".
Bug discovered by buildfarm animal bowerbird.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/c468bd5c087051e2edc573118a42d73a8ae3c3a4
Modified Files
--------------
src/bin/pg_verify_checksums/t/002_actions.pl | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
On Sun, Oct 21, 2018 at 01:03:35PM +0000, Andrew Dunstan wrote:
Don't try to test files named with a trailing dot on Windows
The pg_verify_checksums test tries to create files with corrupt data
named "123." and "123_." But on Windows a file name with a trailing dot
is the same as a file without the trailing dot. In the first case this
will create a file with a "valid" name, which causes the test to fail in
an unexpected way, and in the secongd case this will be redandant as the
test already creates a file named "123_".Bug discovered by buildfarm animal bowerbird.
Thanks Andrew! That property of Windows is actually... Interesting.
Please feel free to ping me on the involved message if I don't see a
buildfarm failure, and I'll investigate.
--
Michael