pgsql: Fix included file path for modern perl
Fix included file path for modern perl
Contrary to the comment on 772d4b76, only paths starting with "./" or
"../" are considered relative to the current working directory by perl's
"do" function. So this patch converts all the relevant cases to use "./"
paths. This only affects MSVC.
Backpatch to all live branches.
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/f83419b7396fe5c64613838fd9eab8424591ad4a
Modified Files
--------------
src/tools/msvc/Install.pm | 4 ++--
src/tools/msvc/build.pl | 6 +++---
src/tools/msvc/install.pl | 2 +-
src/tools/msvc/mkvcbuild.pl | 4 ++--
src/tools/msvc/pgbison.pl | 2 +-
src/tools/msvc/pgflex.pl | 2 +-
src/tools/msvc/vcregress.pl | 6 +++---
7 files changed, 13 insertions(+), 13 deletions(-)
Hi,
On 2019-02-06 00:36:07 +0000, Andrew Dunstan wrote:
Fix included file path for modern perl
Contrary to the comment on 772d4b76, only paths starting with "./" or
"../" are considered relative to the current working directory by perl's
"do" function. So this patch converts all the relevant cases to use "./"
paths. This only affects MSVC.Backpatch to all live branches.
Hm, is it possible this broke
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2019-02-06%2002%3A41%3A15
and
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dory&dt=2019-02-06%2000%3A45%3A25
both report something like
Use of uninitialized value in multiplication (*) at src/tools/msvc/Solution.pm line 181, <$i> line 783.
Use of uninitialized value in division (/) at src/tools/msvc/Solution.pm line 184, <$i> line 783.
Illegal division by zero at src/tools/msvc/Solution.pm line 184, <$i> line 783.
starting with this commit.
Greetings,
Andres Freund
On 2/6/19 4:27 AM, Andres Freund wrote:
Hi,
On 2019-02-06 00:36:07 +0000, Andrew Dunstan wrote:
Fix included file path for modern perl
Contrary to the comment on 772d4b76, only paths starting with "./" or
"../" are considered relative to the current working directory by perl's
"do" function. So this patch converts all the relevant cases to use "./"
paths. This only affects MSVC.Backpatch to all live branches.
Hm, is it possible this broke
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2019-02-06%2002%3A41%3A15
and
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=dory&dt=2019-02-06%2000%3A45%3A25
both report something like
Use of uninitialized value in multiplication (*) at src/tools/msvc/Solution.pm line 181, <$i> line 783.
Use of uninitialized value in division (/) at src/tools/msvc/Solution.pm line 184, <$i> line 783.
Illegal division by zero at src/tools/msvc/Solution.pm line 184, <$i> line 783.starting with this commit.
Yes, investigating ...
cheers
andrew