cs_CZ vs regression tests, part N

Started by Tom Laneabout 17 years ago13 messageshackers
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

It's still broken:
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01

I remain of the opinion that supporting the regression tests in a locale
that works like this is more trouble than it's worth.

regards, tom lane

#2Zdenek Kotala
Zdenek.Kotala@Sun.COM
In reply to: Tom Lane (#1)
Re: cs_CZ vs regression tests, part N

Dne 18.03.09 13:35, Tom Lane napsal(a):

It's still broken:
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01

Yes, it is. But it is PL test now ;-).

I remain of the opinion that supporting the regression tests in a locale
that works like this is more trouble than it's worth.

Problem disappear when collation per column will be implemented. Until
it we need to workaround it somehow.

Zdenek

#3Peter Eisentraut
peter_e@gmx.net
In reply to: Tom Lane (#1)
Re: cs_CZ vs regression tests, part N

Tom Lane wrote:

It's still broken:
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01

I remain of the opinion that supporting the regression tests in a locale
that works like this is more trouble than it's worth.

We looked into this and it turns out that this is actually a C locale
vs. all-other-locales issue; not specific to Czech. More specifically,
it is related to the sorting of upper-case vs. lower-case letters. A
_1.out file is an appropriate answer here.

(Hmm, no one except Zdenek testing locales yet on the build farm? Can't
easily tell from the index page.)

#4Andrew Dunstan
andrew@dunslane.net
In reply to: Peter Eisentraut (#3)
Re: cs_CZ vs regression tests, part N

Peter Eisentraut wrote:

Tom Lane wrote:

It's still broken:
http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-17%2021:06:01

I remain of the opinion that supporting the regression tests in a locale
that works like this is more trouble than it's worth.

We looked into this and it turns out that this is actually a C locale
vs. all-other-locales issue; not specific to Czech. More
specifically, it is related to the sorting of upper-case vs.
lower-case letters. A _1.out file is an appropriate answer here.

(Hmm, no one except Zdenek testing locales yet on the build farm?
Can't easily tell from the index page.)

Yes, dungbeetle is ... I took tcl out of its config until we had this
sorted out. Are you going to commit a _1.out file?

cheers

andrew

#5Zdenek Kotala
Zdenek.Kotala@Sun.COM
In reply to: Peter Eisentraut (#3)
Re: cs_CZ vs regression tests, part N

Peter Eisentraut píše v pá 20. 03. 2009 v 15:33 +0200:

(Hmm, no one except Zdenek testing locales yet on the build farm? Can't
easily tell from the index page.)

It seems to me like good idea to add column with locale list tested on a
animal.

Zdenek

#6Peter Eisentraut
peter_e@gmx.net
In reply to: Andrew Dunstan (#4)
Re: cs_CZ vs regression tests, part N

Andrew Dunstan wrote:

Yes, dungbeetle is ... I took tcl out of its config until we had this
sorted out. Are you going to commit a _1.out file?

Done

#7Peter Eisentraut
peter_e@gmx.net
In reply to: Peter Eisentraut (#6)
Re: cs_CZ vs regression tests, part N+1

Peter Eisentraut wrote:

Andrew Dunstan wrote:

Yes, dungbeetle is ... I took tcl out of its config until we had this
sorted out. Are you going to commit a _1.out file?

Done

Can't catch a break:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01

This time it's the btree_gist and tsearch tests that are complaining,
and this time it is because of the Czech locale rules.

#8Zdenek Kotala
Zdenek.Kotala@Sun.COM
In reply to: Peter Eisentraut (#7)
Re: cs_CZ vs regression tests, part N+1

Dne 24.03.09 08:43, Peter Eisentraut napsal(a):

Peter Eisentraut wrote:

Andrew Dunstan wrote:

Yes, dungbeetle is ... I took tcl out of its config until we had this
sorted out. Are you going to commit a _1.out file?

Done

Can't catch a break:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01

This time it's the btree_gist and tsearch tests that are complaining,
and this time it is because of the Czech locale rules.

Patch attached. I hope last one.

thanks Zdenek

Attachments:

contrib.patch.gzapplication/x-gzip; name=contrib.patch.gzDownload
#9Zdenek Kotala
Zdenek.Kotala@Sun.COM
In reply to: Zdenek Kotala (#8)
Re: cs_CZ vs regression tests, part N+1

Please, can somebody look on this patch? I would like to have green
lights on my buildfarms.

thanks Zdenek

Dne 24.03.09 12:23, Zdenek Kotala napsal(a):

Show quoted text

Dne 24.03.09 08:43, Peter Eisentraut napsal(a):

Peter Eisentraut wrote:

Andrew Dunstan wrote:

Yes, dungbeetle is ... I took tcl out of its config until we had
this sorted out. Are you going to commit a _1.out file?

Done

Can't catch a break:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&dt=2009-03-23%2021:06:01

This time it's the btree_gist and tsearch tests that are complaining,
and this time it is because of the Czech locale rules.

Patch attached. I hope last one.

thanks Zdenek

------------------------------------------------------------------------

#10Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Zdenek Kotala (#9)
Re: cs_CZ vs regression tests, part N+1

This diff in tsearch2.out surprised me:

@@ -2390,7 +2390,7 @@
<body>
<b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i>
<a href="http://www.google.com/foo.bar.html&quot; target="_blank">YES
&nbsp;</a>
- ff-bg
+ ff-bg
<script>
document.write(15);
</script>

Any idea what's causing that?

Zdenek Kotala wrote:

Please, can somebody look on this patch? I would like to have green
lights on my buildfarms.

thanks Zdenek

Dne 24.03.09 12:23, Zdenek Kotala napsal(a):

Dne 24.03.09 08:43, Peter Eisentraut napsal(a):

Peter Eisentraut wrote:

Andrew Dunstan wrote:

Yes, dungbeetle is ... I took tcl out of its config until we had
this sorted out. Are you going to commit a _1.out file?

Done

Can't catch a break:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&amp;dt=2009-03-23%2021:06:01

This time it's the btree_gist and tsearch tests that are complaining,
and this time it is because of the Czech locale rules.

Patch attached. I hope last one.

thanks Zdenek

------------------------------------------------------------------------

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

#11Zdenek Kotala
Zdenek.Kotala@Sun.COM
In reply to: Heikki Linnakangas (#10)
Re: cs_CZ vs regression tests, part N+1

Dne 24.04.09 07:17, Heikki Linnakangas napsal(a):

This diff in tsearch2.out surprised me:

@@ -2390,7 +2390,7 @@
<body>
<b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i>
<a href="http://www.google.com/foo.bar.html&quot; target="_blank">YES
&nbsp;</a>
- ff-bg
+ ff-bg
<script>
document.write(15);
</script>

Any idea what's causing that?

Good catch. I don't see it on

http://www.pgbuildfarm.org/cgi-bin/show_log.pl?nm=comet_moth&amp;dt=2009-04-24%2004:47:44

I'm playing with it now. Unfortunately I don't have my laptop with
workspace now.

Thanks Zdenek

Show quoted text

Zdenek Kotala wrote:

Please, can somebody look on this patch? I would like to have green
lights on my buildfarms.

thanks Zdenek

Dne 24.03.09 12:23, Zdenek Kotala napsal(a):

Dne 24.03.09 08:43, Peter Eisentraut napsal(a):

Peter Eisentraut wrote:

Andrew Dunstan wrote:

Yes, dungbeetle is ... I took tcl out of its config until we had
this sorted out. Are you going to commit a _1.out file?

Done

Can't catch a break:
http://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=gothic_moth&amp;dt=2009-03-23%2021:06:01

This time it's the btree_gist and tsearch tests that are
complaining, and this time it is because of the Czech locale rules.

Patch attached. I hope last one.

thanks Zdenek

------------------------------------------------------------------------

#12Zdenek Kotala
Zdenek.Kotala@Sun.COM
In reply to: Heikki Linnakangas (#10)
Re: cs_CZ vs regression tests, part N+1

Dne 24.04.09 07:17, Heikki Linnakangas napsal(a):

This diff in tsearch2.out surprised me:

@@ -2390,7 +2390,7 @@
<body>
<b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i>
<a href="http://www.google.com/foo.bar.html&quot; target="_blank">YES
&nbsp;</a>
- ff-bg
+ ff-bg
<script>
document.write(15);
</script>

Any idea what's causing that?

Hmm. I don't understand it. I'm not able to generate this again nad I
don't have idea why it happend. It is definitely wrong. Shell I sent you
new diff or do you fix it yourself?

Thanks Zdenek

#13Heikki Linnakangas
heikki.linnakangas@enterprisedb.com
In reply to: Zdenek Kotala (#12)
Re: cs_CZ vs regression tests, part N+1

Zdenek Kotala wrote:

Dne 24.04.09 07:17, Heikki Linnakangas napsal(a):

This diff in tsearch2.out surprised me:

@@ -2390,7 +2390,7 @@
<body>
<b>Sea</b> view wow <u><b>foo</b> bar</u> <i>qq</i>
<a href="http://www.google.com/foo.bar.html&quot; target="_blank">YES
&nbsp;</a>
- ff-bg
+ ff-bg
<script>
document.write(15);
</script>

Any idea what's causing that?

Hmm. I don't understand it. I'm not able to generate this again nad I
don't have idea why it happend. It is definitely wrong. Shell I sent you
new diff or do you fix it yourself?

Committed, without that mystery change.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com