pgsql: Stabilize contrib/seg regression test.

Started by Tom Laneabout 5 years ago3 messagescomitters
Jump to latest
#1Tom Lane
tgl@sss.pgh.pa.us

Stabilize contrib/seg regression test.

If autovacuum comes along just after we fill table test_seg with
some data, it will update the stats to the point where we prefer
a plain indexscan over a bitmap scan, breaking the expected
output (as well as the point of the test case). To fix, just
force a bitmap scan to be chosen here.

This has evidently been wrong since commit de1d042f5. It's not
clear why we just recently saw any buildfarm failures due to it;
but prairiedog has failed twice on this test in the past week.
Hence, backpatch to v11 where this test case came in.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d16ebfbff74b30c83a4669a1df318cacfa7e52ca

Modified Files
--------------
contrib/seg/expected/seg.out | 2 ++
contrib/seg/sql/seg.sql | 2 ++
2 files changed, 4 insertions(+)

#2Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#1)
Re: pgsql: Stabilize contrib/seg regression test.

On 6/7/21 2:53 PM, Tom Lane wrote:

Stabilize contrib/seg regression test.

If autovacuum comes along just after we fill table test_seg with
some data, it will update the stats to the point where we prefer
a plain indexscan over a bitmap scan, breaking the expected
output (as well as the point of the test case). To fix, just
force a bitmap scan to be chosen here.

This has evidently been wrong since commit de1d042f5. It's not
clear why we just recently saw any buildfarm failures due to it;
but prairiedog has failed twice on this test in the past week.
Hence, backpatch to v11 where this test case came in.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d16ebfbff74b30c83a4669a1df318cacfa7e52ca

Modified Files
--------------
contrib/seg/expected/seg.out | 2 ++
contrib/seg/sql/seg.sql | 2 ++
2 files changed, 4 insertions(+)

Looks like you forgot seg_1.out

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Dunstan (#2)
Re: pgsql: Stabilize contrib/seg regression test.

Andrew Dunstan <andrew@dunslane.net> writes:

Looks like you forgot seg_1.out

So I did :-( ... will fix in a bit.

regards, tom lane