pgsql: Reduce running time of jsonb_sqljson test

Started by Andrew Dunstanabout 4 years ago2 messagescomitters
Jump to latest
#1Andrew Dunstan
andrew@dunslane.net

Reduce running time of jsonb_sqljson test

The test created a 1m row table in order to test parallel operation of
JSON_VALUE. However, this was more than were needed for the test, so
save time by halving it, and also by making the table unlogged.
Experimentation shows that this size is only a little above the number
required to generate the expected output.

Per gripe from Andres Freund

Discussion: /messages/by-id/20220406022118.3ocqvhxr6kciw5am@alap3.anarazel.de

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2ef6f11b0c77ec323c688ddfd98ffabddb72c11d

Modified Files
--------------
src/test/regress/expected/jsonb_sqljson.out | 8 ++++----
src/test/regress/sql/jsonb_sqljson.sql | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Dunstan (#1)
Re: pgsql: Reduce running time of jsonb_sqljson test

Andrew Dunstan <andrew@dunslane.net> writes:

The test created a 1m row table in order to test parallel operation of
JSON_VALUE.

Egad.

However, this was more than were needed for the test, so
save time by halving it, and also by making the table unlogged.

This seems like a rather inappropriate fix. I would say that a test
of this size does not belong in the core regression tests AT ALL.

regards, tom lane