pgsql: Doc: un-break PDF build.

Started by Tom Laneover 2 years ago10 messagescomitters

Jump to latest

Tom Lane

tgl@sss.pgh.pa.us

over 2 years ago

Doc: un-break PDF build.

Oversight in 5c4c7efad: gotta adjust the cell height for removal of
an entry. Per buildfarm.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/798394c6ccdada517c3508047a865d9994bfe25f

Modified Files
--------------
doc/src/sgml/gin.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Bruce Momjian

bruce@momjian.us

over 2 years ago

In reply to: Tom Lane (#1)

Re: pgsql: Doc: un-break PDF build.

Thanks, I missed that issue.

---------------------------------------------------------------------------

On Sat, Nov 25, 2023 at 01:03:11AM +0000, Tom Lane wrote:

Doc: un-break PDF build.

Oversight in 5c4c7efad: gotta adjust the cell height for removal of
an entry. Per buildfarm.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/798394c6ccdada517c3508047a865d9994bfe25f

Modified Files
--------------
doc/src/sgml/gin.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

Bruce Momjian

bruce@momjian.us

over 2 years ago

In reply to: Bruce Momjian (#2)

Re: pgsql: Doc: un-break PDF build.

On Fri, Nov 24, 2023 at 08:16:12PM -0500, Bruce Momjian wrote:

Thanks, I missed that issue.

Can someone tell me how you saw that warning in the build farm? I don't
see it in with a make check or a build of the docs.

Attached is the patch that fixed it.

---------------------------------------------------------------------------

On Sat, Nov 25, 2023 at 01:03:11AM +0000, Tom Lane wrote:

Doc: un-break PDF build.

Oversight in 5c4c7efad: gotta adjust the cell height for removal of
an entry. Per buildfarm.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/798394c6ccdada517c3508047a865d9994bfe25f

Modified Files
--------------
doc/src/sgml/gin.sgml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

Tom Lane

tgl@sss.pgh.pa.us

over 2 years ago

In reply to: Bruce Momjian (#3)

Re: pgsql: Doc: un-break PDF build.

Bruce Momjian <bruce@momjian.us> writes:

Can someone tell me how you saw that warning in the build farm? I don't
see it in with a make check or a build of the docs.

Yeah, for some reason it only shows up when building PDFs.

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10

regards, tom lane

Bruce Momjian

bruce@momjian.us

over 2 years ago

In reply to: Tom Lane (#4)

Re: pgsql: Doc: un-break PDF build.

On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

Can someone tell me how you saw that warning in the build farm? I don't
see it in with a make check or a build of the docs.

Yeah, for some reason it only shows up when building PDFs.

https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10

Odd, I don't see that here. Maybe I need an upgraded toolchain:

$ make postgres-A4.pdf 2>&1 | grep -v INFO
/usr/bin/xsltproc --nonet --path . --path . --stringparam pg.version '17devel' --stringparam img.src.path './' --stringparam paper.type A4 -o postgres-A4.fo stylesheet-fo.xsl postgres-full.xml
Making portrait pages on A4 paper (210mmx297mm)
/usr/bin/fop -fo postgres-A4.fo -pdf postgres-A4.pdf
[warning] /usr/bin/fop: JVM flavor 'sun' not understood
[WARN] FOUserAgent - Font "Symbol,normal,700" not found. Substituting with "Symbol,normal,400".
[WARN] FOUserAgent - Font "ZapfDingbats,normal,700" not found. Substituting with "ZapfDingbats,normal,400".
[WARN] PropertyMaker - span="inherit" on fo:block, but no explicit value found on the parent FO.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

Tom Lane

tgl@sss.pgh.pa.us

over 2 years ago

In reply to: Bruce Momjian (#5)

Re: pgsql: Doc: un-break PDF build.

Bruce Momjian <bruce@momjian.us> writes:

On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote:

Yeah, for some reason it only shows up when building PDFs.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10

Odd, I don't see that here. Maybe I need an upgraded toolchain:

Hmm, I did see it here, using fop 2.5 and docbook 1.79.

regards, tom lane

Bruce Momjian

bruce@momjian.us

over 2 years ago

In reply to: Tom Lane (#6)

Re: pgsql: Doc: un-break PDF build.

On Sat, Nov 25, 2023 at 11:26:16AM -0500, Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote:

Yeah, for some reason it only shows up when building PDFs.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10

Odd, I don't see that here. Maybe I need an upgraded toolchain:

Hmm, I did see it here, using fop 2.5 and docbook 1.79.

Uh, I have on Debian 12 (bookworm):

fop is 2.8
ii fop 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - app
ii libfop-java 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - libs

docbook is 1.79
ii docbook 4.5-10 all standard SGML representation system for technical documents
ii docbook-dsssl 1.79-10 all modular DocBook DSSSL stylesheets, for print and HTML
ii docbook-xml 4.5-12 all standard XML documentation system for software and systems
ii docbook-xsl 1.79.2+dfsg-2 all stylesheets for processing DocBook XML to various output formats
ii docbook-xsl-doc-html 1.79.1-1 all stylesheets for processing DocBook XML files (HTML documentation)

Kind of odd I don't see it the error.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

Andrew Dunstan

andrew@dunslane.net

over 2 years ago

In reply to: Bruce Momjian (#7)

Re: pgsql: Doc: un-break PDF build.

On 2023-11-25 Sa 11:34, Bruce Momjian wrote:

On Sat, Nov 25, 2023 at 11:26:16AM -0500, Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote:

Yeah, for some reason it only shows up when building PDFs.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10

Odd, I don't see that here. Maybe I need an upgraded toolchain:

Hmm, I did see it here, using fop 2.5 and docbook 1.79.

Uh, I have on Debian 12 (bookworm):

fop is 2.8
ii fop 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - app
ii libfop-java 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - libs

docbook is 1.79
ii docbook 4.5-10 all standard SGML representation system for technical documents
ii docbook-dsssl 1.79-10 all modular DocBook DSSSL stylesheets, for print and HTML
ii docbook-xml 4.5-12 all standard XML documentation system for software and systems
ii docbook-xsl 1.79.2+dfsg-2 all stylesheets for processing DocBook XML to various output formats
ii docbook-xsl-doc-html 1.79.1-1 all stylesheets for processing DocBook XML files (HTML documentation)

Kind of odd I don't see it the error.

What command are you invoking to build the docs? The default docs make
target doesn't build the PDFs - you have to build those explicitly.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

Bruce Momjian

bruce@momjian.us

over 2 years ago

In reply to: Andrew Dunstan (#8)

Re: pgsql: Doc: un-break PDF build.

On Sat, Nov 25, 2023 at 02:14:11PM -0500, Andrew Dunstan wrote:

On 2023-11-25 Sa 11:34, Bruce Momjian wrote:

On Sat, Nov 25, 2023 at 11:26:16AM -0500, Tom Lane wrote:

Bruce Momjian <bruce@momjian.us> writes:

On Sat, Nov 25, 2023 at 10:50:10AM -0500, Tom Lane wrote:

Yeah, for some reason it only shows up when building PDFs.
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=alabio&dt=2023-11-25%2000%3A02%3A10

Odd, I don't see that here. Maybe I need an upgraded toolchain:

Hmm, I did see it here, using fop 2.5 and docbook 1.79.

Uh, I have on Debian 12 (bookworm):

fop is 2.8
ii fop 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - app
ii libfop-java 1:2.8-2 all XML formatter driven by XSL Formatting Objects (XSL-FO.) - libs

docbook is 1.79
ii docbook 4.5-10 all standard SGML representation system for technical documents
ii docbook-dsssl 1.79-10 all modular DocBook DSSSL stylesheets, for print and HTML
ii docbook-xml 4.5-12 all standard XML documentation system for software and systems
ii docbook-xsl 1.79.2+dfsg-2 all stylesheets for processing DocBook XML to various output formats
ii docbook-xsl-doc-html 1.79.1-1 all stylesheets for processing DocBook XML files (HTML documentation)

Kind of odd I don't see it the error.

What command are you invoking to build the docs? The default docs make
target doesn't build the PDFs - you have to build those explicitly.

I showed it previously in this thread:

$ make postgres-A4.pdf 2>&1 | grep -v INFO
/usr/bin/xsltproc --nonet --path . --path . --stringparam pg.version '17devel' --stringparam img.src.path './' --stringparam paper.type A4 -o postgres-A4.fo
+stylesheet-fo.xsl postgres-full.xml
Making portrait pages on A4 paper (210mmx297mm)
/usr/bin/fop -fo postgres-A4.fo -pdf postgres-A4.pdf
[warning] /usr/bin/fop: JVM flavor 'sun' not understood
[WARN] FOUserAgent - Font "Symbol,normal,700" not found. Substituting with "Symbol,normal,400".
[WARN] FOUserAgent - Font "ZapfDingbats,normal,700" not found. Substituting with "ZapfDingbats,normal,400".
[WARN] PropertyMaker - span="inherit" on fo:block, but no explicit value found on the parent FO.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

#10

Bruce Momjian

bruce@momjian.us

over 2 years ago

In reply to: Bruce Momjian (#9)

Re: pgsql: Doc: un-break PDF build.

On Sat, Nov 25, 2023 at 02:18:43PM -0500, Bruce Momjian wrote:

I showed it previously in this thread:

$ make postgres-A4.pdf 2>&1 | grep -v INFO
/usr/bin/xsltproc --nonet --path . --path . --stringparam pg.version '17devel' --stringparam img.src.path './' --stringparam paper.type A4 -o postgres-A4.fo
+stylesheet-fo.xsl postgres-full.xml
Making portrait pages on A4 paper (210mmx297mm)
/usr/bin/fop -fo postgres-A4.fo -pdf postgres-A4.pdf
[warning] /usr/bin/fop: JVM flavor 'sun' not understood
[WARN] FOUserAgent - Font "Symbol,normal,700" not found. Substituting with "Symbol,normal,400".
[WARN] FOUserAgent - Font "ZapfDingbats,normal,700" not found. Substituting with "ZapfDingbats,normal,400".
[WARN] PropertyMaker - span="inherit" on fo:block, but no explicit value found on the parent FO.

Oops, please disregard my report. I was able to reproduce the failure
just now. I must have incorrectly applied the patch in testing.
Mystery solved.

I am not sure if I am going to build the PDF for every doc patch, but at
least I can do it when I am concerned, and know how to reproduce it if
the buildfarm fails.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

pgsql: Doc: un-break PDF build.

Attachments: