pgsql: scripts: add Perl script to add links to release notes

Started by Bruce Momjianalmost 2 years ago3 messagescomitters
Jump to latest
#1Bruce Momjian
bruce@momjian.us

scripts: add Perl script to add links to release notes

Reported-by: jian he

Discussion: /messages/by-id/ZuYsS5XdA7hVcV9l@momjian.us

Backpatch-through: 12

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/257210455257aaac30001914886d422cbf34c215

Modified Files
--------------
src/tools/RELEASE_CHANGES | 1 +
src/tools/add_commit_links.pl | 136 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 137 insertions(+)

#2Andrew Dunstan
andrew@dunslane.net
In reply to: Bruce Momjian (#1)
Re: pgsql: scripts: add Perl script to add links to release notes

On 2024-09-16 Mo 1:27 PM, Bruce Momjian wrote:

scripts: add Perl script to add links to release notes

Reported-by: jian he

Discussion:/messages/by-id/ZuYsS5XdA7hVcV9l@momjian.us

I realize I'm late to the party on this, but here's a review patch for
this script. It's mostly stylistic changes (simpler use of print, use of
POSIX xdigit class for hex digits), but it does correct one actual
error: AFAIK "die" doesn't do printf style substitutions.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

Attachments:

add_commit_links.patchtext/x-patch; charset=UTF-8; name=add_commit_links.patchDownload+9-12
#3Bruce Momjian
bruce@momjian.us
In reply to: Andrew Dunstan (#2)
Re: pgsql: scripts: add Perl script to add links to release notes

On Tue, Sep 17, 2024 at 09:47:57AM -0400, Andrew Dunstan wrote:

On 2024-09-16 Mo 1:27 PM, Bruce Momjian wrote:

scripts: add Perl script to add links to release notes

Reported-by: jian he

Discussion: /messages/by-id/ZuYsS5XdA7hVcV9l@momjian.us

I realize I'm late to the party on this, but here's a review patch for this
script. It's mostly stylistic changes (simpler use of print, use of POSIX
xdigit class for hex digits), but it does correct one actual error: AFAIK "die"
doesn't do printf style substitutions.

Patch applied. Sorry for the delay.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"