ecpg tests broken by pgindent run

Tom Lane wrote:

Hey Bruce, I thought the ecpg test files were supposed to be excluded
from pgindenting? The buildfarm is all red, or would be if you could
see it.

Well, I am excluding them:

find . -name '*.[ch]' -type f -print |
egrep -v '/s_lock.h|/ecpg/test/expected/|/snowball/libstemmer/' |
xargs -n100 pgindent src/tools/pgindent/typedefs.list

with '/ecpg/test/expected/'. When I run the the ecpg regression tests
I do see failures like:

	*** /usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.c    Wed Jan  6 06:59:52 2010
	--- /usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/test/results/compat_informix-sqlda.c Fri Feb 26 11:20:25 2010
	***************
	*** 32,49 ****
	  #ifdef _ECPG_INFORMIX_H

#include "sqlda-compat.h"
! typedef struct sqlvar_compat sqlvar_t;
! typedef struct sqlda_compat sqlda_t;
!
#else

#include "sqlda-native.h"
! typedef struct sqlvar_struct sqlvar_t;
! typedef struct sqlda_struct sqlda_t;
!
#endif

! #endif /* ECPG_SQLDA_H */

#line 7 "sqlda.pgc"

	--- 32,47 ----
	  #ifdef _ECPG_INFORMIX_H

#include "sqlda-compat.h"
! typedef struct sqlvar_compat sqlvar_t;
! typedef struct sqlda_compat sqlda_t;
#else

#include "sqlda-native.h"
! typedef struct sqlvar_struct sqlvar_t;
! typedef struct sqlda_struct sqlda_t;
#endif

! #endif /* ECPG_SQLDA_H */

#line 7 "sqlda.pgc"

but if I look at the CVS history for
/cvsroot/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.c
I see the last change was January 6, not from pgindent.

My only guess is that there was some boilerplate code in the ecpg C
files or outside /test which changed when ran pgindent.

I am researching now.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +

Bruce Momjian �rta:

Tom Lane wrote:

Hey Bruce, I thought the ecpg test files were supposed to be excluded
from pgindenting? The buildfarm is all red, or would be if you could
see it.

Well, I am excluding them:

find . -name '*.[ch]' -type f -print |
egrep -v '/s_lock.h|/ecpg/test/expected/|/snowball/libstemmer/' |
xargs -n100 pgindent src/tools/pgindent/typedefs.list

with '/ecpg/test/expected/'. When I run the the ecpg regression tests
I do see failures like:

*** /usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.c    Wed Jan  6 06:59:52 2010
--- /usr/var/local/src/gen/pgsql/CURRENT/pgsql/src/interfaces/ecpg/test/results/compat_informix-sqlda.c Fri Feb 26 11:20:25 2010
***************
*** 32,49 ****
#ifdef _ECPG_INFORMIX_H

#include "sqlda-compat.h"
! typedef struct sqlvar_compat sqlvar_t;
! typedef struct sqlda_compat sqlda_t;
!
#else

#include "sqlda-native.h"
! typedef struct sqlvar_struct sqlvar_t;
! typedef struct sqlda_struct sqlda_t;
!
#endif

! #endif /* ECPG_SQLDA_H */

#line 7 "sqlda.pgc"

--- 32,47 ----
#ifdef _ECPG_INFORMIX_H

#include "sqlda-compat.h"
! typedef struct sqlvar_compat sqlvar_t;
! typedef struct sqlda_compat sqlda_t;
#else

#include "sqlda-native.h"
! typedef struct sqlvar_struct sqlvar_t;
! typedef struct sqlda_struct sqlda_t;
#endif

! #endif /* ECPG_SQLDA_H */

#line 7 "sqlda.pgc"

but if I look at the CVS history for
/cvsroot/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.c
I see the last change was January 6, not from pgindent.

My only guess is that there was some boilerplate code in the ecpg C
files or outside /test which changed when ran pgindent.

I am researching now.

Don't look further, interfaces/ecpg/include/sqlda.h has changed
by the pgindent run.

--
Bible has answers for everything. Proof:
"But let your communication be, Yea, yea; Nay, nay: for whatsoever is more
than these cometh of evil." (Matthew 5:37) - basics of digital technology.
"May your kingdom come" - superficial description of plate tectonics

----------------------------------
Zolt�n B�sz�rm�nyi
Cybertec Sch�nig & Sch�nig GmbH
http://www.postgresql.at/

Boszormenyi Zoltan wrote:

but if I look at the CVS history for
/cvsroot/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.c
I see the last change was January 6, not from pgindent.

My only guess is that there was some boilerplate code in the ecpg C
files or outside /test which changed when ran pgindent.

I am researching now.

Don't look further, interfaces/ecpg/include/sqlda.h has changed
by the pgindent run.

Yea, it is that, and sqltypes.h and one other file I am trying to find
now.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:

Boszormenyi Zoltan wrote:

but if I look at the CVS history for
/cvsroot/pgsql/src/interfaces/ecpg/test/expected/compat_informix-sqlda.c
I see the last change was January 6, not from pgindent.

My only guess is that there was some boilerplate code in the ecpg C
files or outside /test which changed when ran pgindent.

I am researching now.

Don't look further, interfaces/ecpg/include/sqlda.h has changed
by the pgindent run.

Yea, it is that, and sqltypes.h and one other file I am trying to find
now.

I have reverted changes to three include files who's output appears in
the regression tests. I asssume this is new 9.0 behavior because I
didn't have this issue before. I also updated the pgindent script to
prevent these from being changed in the future.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +

Bruce Momjian wrote:

Don't look further, interfaces/ecpg/include/sqlda.h has changed
by the pgindent run.

Yea, it is that, and sqltypes.h and one other file I am trying to find
now.

I have reverted changes to three include files who's output appears in
the regression tests. I asssume this is new 9.0 behavior because I
didn't have this issue before. I also updated the pgindent script to
prevent these from being changed in the future.

Should not the instructions include doing a full set of regression tests
to ensure that nothing breaks? The new installcheck-world target should
help there.

cheers

andrew

Andrew Dunstan wrote:

Bruce Momjian wrote:

Don't look further, interfaces/ecpg/include/sqlda.h has changed
by the pgindent run.

Yea, it is that, and sqltypes.h and one other file I am trying to find
now.

I have reverted changes to three include files who's output appears in
the regression tests. I asssume this is new 9.0 behavior because I
didn't have this issue before. I also updated the pgindent script to
prevent these from being changed in the future.

Should not the instructions include doing a full set of regression tests
to ensure that nothing breaks? The new installcheck-world target should
help there.

Wow, I didn't know that was available. I have updated the pgindent
README.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com
  PG East:  http://www.enterprisedb.com/community/nav-pg-east-2010.do
  + If your life is a hard drive, Christ can be your backup. +