message style for errcontext

Peter Eisentraut <peter_e@gmx.net> writes:

We have in 9.0 plperl.c
errcontext("while executing PostgreSQL::InServer::SPI::bootstrap")));
errcontext("while parsing Perl initialization")));
errcontext("while running Perl initialization")));
errcontext("While executing PLC_TRUSTED.")));
errcontext("While executing utf8fix.")));
errcontext("While executing plperl.on_plperl_init.")));
errcontext("while executing plperl.on_plperlu_init")));

Could we agree on a capitalization and punctuation scheme?

Instances of errcontext() elsewhere don't use either initcap or
terminating period. I think that's probably good to stick with,
but the message guidelines need to document that these messages
shouldn't follow the "full sentence" style.

regards, tom lane

Peter Eisentraut wrote:

We have in 9.0 plperl.c

errcontext("while executing PostgreSQL::InServer::SPI::bootstrap")));
errcontext("while parsing Perl initialization")));
errcontext("while running Perl initialization")));
errcontext("While executing PLC_TRUSTED.")));
errcontext("While executing utf8fix.")));
errcontext("While executing plperl.on_plperl_init.")));
errcontext("while executing plperl.on_plperlu_init")));

Could we agree on a capitalization and punctuation scheme?

Sure. Sorry about that. Looking at other uses it looks like the most
consistent would be to have no initial cap and no trailing period. I'll
adjust it that way if you like. Is there anything else you want adjusted?

cheers

andrew

On May 17, 2010, at 11:20 AM, Peter Eisentraut wrote:

We have in 9.0 plperl.c

errcontext("while executing PostgreSQL::InServer::SPI::bootstrap")));
errcontext("while parsing Perl initialization")));
errcontext("while running Perl initialization")));
errcontext("While executing PLC_TRUSTED.")));
errcontext("While executing utf8fix.")));
errcontext("While executing plperl.on_plperl_init.")));
errcontext("while executing plperl.on_plperlu_init")));

Could we agree on a capitalization and punctuation scheme?

Oh, this reminds me. Is there a way to get at errcontext data from PL/pgSQL? I'm assuming there's something to complement SQLSTATE and SQLERRM, yes?

Thanks,

David