pgsql: pg_waldump: Preparatory refactoring for tar archive WAL decoding

Started by Andrew Dunstan3 months ago1 messagescomitters
Jump to latest
#1Andrew Dunstan
andrew@dunslane.net

pg_waldump: Preparatory refactoring for tar archive WAL decoding.

Several refactoring steps in preparation for adding tar archive WAL
decoding support to pg_waldump:

- Move XLogDumpPrivate and related declarations into a new pg_waldump.h
header, allowing a second source file to share them.

- Factor out required_read_len() so the read-size calculation can be
reused for both regular WAL files and tar-archived WAL.

- Move the WAL segment size variable into XLogDumpPrivate and rename it
to segsize, making it accessible to the archive streamer code.

Author: Amul Sul <sulamul@gmail.com>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Jakub Wartak <jakub.wartak@enterprisedb.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: Euler Taveira <euler@eulerto.com>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
discussion: /messages/by-id/CAAJ_b94bqdWN3h2J-PzzzQ2Npbwct5ZQHggn_QoYGhC2rn-=WQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f8a0cd26717063b99d846b693b416187ab56d67b

Modified Files
--------------
src/bin/pg_waldump/pg_waldump.c | 78 +++++++++++++++++++++++------------------
src/bin/pg_waldump/pg_waldump.h | 26 ++++++++++++++
2 files changed, 70 insertions(+), 34 deletions(-)