pgsql: Use command_ok for pg_regress calls in 002_pg_upgrade and 027_st

Started by Andrew Dunstan3 months ago1 messagescomitters

andrew@dunslane.net

3 months ago

Use command_ok for pg_regress calls in 002_pg_upgrade and 027_stream_regress

Now that command_ok() captures and displays failure output, use it
instead of system() plus manual diff-dumping in these two tests. This
simplifies both scripts and produces consistent, truncated output on
failure.

Author: Jelte Fennema-Nio <postgres@jeltef.nl>
Reviewed-by: Andrew Dunstan <andrew@dunslane.net>
Reviewed-by: Corey Huinker <corey.huinker@gmail.com>
Discussion: /messages/by-id/DFYFWM053WHS.10K8ZPJ605UFK@jeltef.nl

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/bb6ae9707c1789c9d2036c9bbd35965a01e1b214

Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 40 ++++++++--------------
src/test/recovery/t/027_stream_regress.pl | 55 +++++++++----------------------
2 files changed, 29 insertions(+), 66 deletions(-)