Added Encoding

Started by Eiji Tokuyaover 24 years ago23 messagespatches
Jump to latest
#1Eiji Tokuya
e-tokuya@sankyo-unyu.co.jp

It was made to cope with encoding such as an Asian bloc in 7.2Beta2.

Added ServerEncoding
Korean (JOHAB), Thai (WIN874),
Vietnamese (TCVN), Arabic (WIN1256)

Added ClientEncoding
Simplified Chinese (GBK), Korean (UHC)

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2b2.newencoding.diff.tar.gz
(608K)

Eiji Tokuya

#2Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#1)
Re: Added Encoding

It was made to cope with encoding such as an Asian bloc in 7.2Beta2.

Added ServerEncoding
Korean (JOHAB), Thai (WIN874),
Vietnamese (TCVN), Arabic (WIN1256)

Added ClientEncoding
Simplified Chinese (GBK), Korean (UHC)

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2b2.newencoding.diff.tar.gz
(608K)

Looks good. I need some people to review this for me. The diff is 3mb
but appears to address only additions to multibyte. I have attached a
list of files it modifies. Also, look at the sizes of the mb/
directory. It is getting large:

4 ./CVS
6 ./Unicode/CVS
3433 ./Unicode
6197 .

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026

Attachments:

/bjm/difftext/plainDownload
#3Tatsuo Ishii
ishii@postgresql.org
In reply to: Bruce Momjian (#2)
Re: Added Encoding

It was made to cope with encoding such as an Asian bloc in 7.2Beta2.

Added ServerEncoding
Korean (JOHAB), Thai (WIN874),
Vietnamese (TCVN), Arabic (WIN1256)

Added ClientEncoding
Simplified Chinese (GBK), Korean (UHC)

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2b2.newencoding.diff.tar.gz
(608K)

Looks good. I need some people to review this for me.

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

The diff is 3mb
but appears to address only additions to multibyte. I have attached a
list of files it modifies. Also, look at the sizes of the mb/
directory. It is getting large:

4 ./CVS
6 ./Unicode/CVS
3433 ./Unicode
6197 .

Yes. We definitely need the on-the-fly encoding addition capability:
i.e. CREATE CHRACTER SET in the future...
--
Tatsuo Ishii

#4Bruce Momjian
bruce@momjian.us
In reply to: Tatsuo Ishii (#3)
Re: Added Encoding

It was made to cope with encoding such as an Asian bloc in 7.2Beta2.

Added ServerEncoding
Korean (JOHAB), Thai (WIN874),
Vietnamese (TCVN), Arabic (WIN1256)

Added ClientEncoding
Simplified Chinese (GBK), Korean (UHC)

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2b2.newencoding.diff.tar.gz
(608K)

Looks good. I need some people to review this for me.

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

OK, when do we apply it? It seems isolated to the encoding stuff.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#5Tatsuo Ishii
ishii@postgresql.org
In reply to: Bruce Momjian (#4)
Re: Added Encoding

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

OK, when do we apply it? It seems isolated to the encoding stuff.

Yes, I think it's safe to apply them for 7.2.
--
Tatsuo Ishii

#6Bruce Momjian
bruce@momjian.us
In reply to: Tatsuo Ishii (#5)
Re: Added Encoding

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

OK, when do we apply it? It seems isolated to the encoding stuff.

Yes, I think it's safe to apply them for 7.2.

OK, I think I need a second "yes" vote on this because of the size of
the patch. However, few people know as much as Tatsuo about multibyte,
so I will wait 24 hours and apply unless someone objects.

I will place it in the unapplied patches queue so people can see it.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#7Vince Vielhaber
vev@michvhf.com
In reply to: Bruce Momjian (#6)
Re: Added Encoding

On Sun, 25 Nov 2001, Bruce Momjian wrote:

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

OK, when do we apply it? It seems isolated to the encoding stuff.

Yes, I think it's safe to apply them for 7.2.

OK, I think I need a second "yes" vote on this because of the size of
the patch. However, few people know as much as Tatsuo about multibyte,
so I will wait 24 hours and apply unless someone objects.

We've come along way since the days of 6.2 or 6.3 when every time Marc
wasn't paying attention a few more things were added during beta. We're
into beta 2 or 3 now (I haven't seen the official b3 announcement yet),
isn't it a bit late to be adding? I've seen quite a few complaints from
you guys about not being into RC mode yet, this will require at least a
beta 4 and possible beta 5 if there's a problem, no matter who the person
is or how much they know about anything.

Vince.
--
==========================================================================
Vince Vielhaber -- KA8CSH email: vev@michvhf.com http://www.pop4.net
56K Nationwide Dialup from $16.00/mo at Pop4 Networking
Online Campground Directory http://www.camping-usa.com
Online Giftshop Superstore http://www.cloudninegifts.com
==========================================================================

#8Bruce Momjian
bruce@momjian.us
In reply to: Vince Vielhaber (#7)
Re: Added Encoding

On Sun, 25 Nov 2001, Bruce Momjian wrote:

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

OK, when do we apply it? It seems isolated to the encoding stuff.

Yes, I think it's safe to apply them for 7.2.

OK, I think I need a second "yes" vote on this because of the size of
the patch. However, few people know as much as Tatsuo about multibyte,
so I will wait 24 hours and apply unless someone objects.

We've come along way since the days of 6.2 or 6.3 when every time Marc
wasn't paying attention a few more things were added during beta. We're
into beta 2 or 3 now (I haven't seen the official b3 announcement yet),
isn't it a bit late to be adding? I've seen quite a few complaints from
you guys about not being into RC mode yet, this will require at least a
beta 4 and possible beta 5 if there's a problem, no matter who the person
is or how much they know about anything.

OK, we have a _no_ vote. Tatsuo, unless you can get quite a few _yes_
votes, I don't think this is going to make it into 7.2.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#9Tom Lane
tgl@sss.pgh.pa.us
In reply to: Vince Vielhaber (#7)
Re: Added Encoding

Vince Vielhaber <vev@zippy.pop4.net> writes:

isn't it a bit late to be adding?

I tend to agree with Vince. A new encoding is clearly a new feature
and so should be held for the next development cycle. If we make
exceptions because "it looks safe", we'll never get out of beta.

regards, tom lane

#10Bruce Momjian
bruce@momjian.us
In reply to: Tatsuo Ishii (#3)
Re: Added Encoding

Was this ever added? I can't find it.

---------------------------------------------------------------------------

Tatsuo Ishii wrote:

It was made to cope with encoding such as an Asian bloc in 7.2Beta2.

Added ServerEncoding
Korean (JOHAB), Thai (WIN874),
Vietnamese (TCVN), Arabic (WIN1256)

Added ClientEncoding
Simplified Chinese (GBK), Korean (UHC)

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2b2.newencoding.diff.tar.gz
(608K)

Looks good. I need some people to review this for me.

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

The diff is 3mb
but appears to address only additions to multibyte. I have attached a
list of files it modifies. Also, look at the sizes of the mb/
directory. It is getting large:

4 ./CVS
6 ./Unicode/CVS
3433 ./Unicode
6197 .

Yes. We definitely need the on-the-fly encoding addition capability:
i.e. CREATE CHRACTER SET in the future...
--
Tatsuo Ishii

---------------------------(end of broadcast)---------------------------
TIP 1: subscribe and unsubscribe commands go to majordomo@postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#11Eiji Tokuya
e-tokuya@sankyo-unyu.jp
In reply to: Bruce Momjian (#10)
Re: Added Encoding

-----Original Message-----
From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
Sent: Saturday, February 23, 2002 8:27 AM
To: Tatsuo Ishii
Cc: e-tokuya@sankyo-unyu.co.jp; pgsql-patches@postgresql.org
Subject: Re: [PATCHES] Added Encoding

Was this ever added? I can't find it.

------------------------------------------------------------------
---------

Tatsuo Ishii wrote:

It was made to cope with encoding such as an Asian bloc in 7.2Beta2.

Added ServerEncoding
Korean (JOHAB), Thai (WIN874),
Vietnamese (TCVN), Arabic (WIN1256)

Added ClientEncoding
Simplified Chinese (GBK), Korean (UHC)

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2b2.newencoding.diff.tar.gz

(608K)

Looks good. I need some people to review this for me.

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

The diff is 3mb
but appears to address only additions to multibyte. I have attached a
list of files it modifies. Also, look at the sizes of the mb/
directory. It is getting large:

4 ./CVS
6 ./Unicode/CVS
3433 ./Unicode
6197 .

Yes. We definitely need the on-the-fly encoding addition capability:
i.e. CREATE CHRACTER SET in the future...
--
Tatsuo Ishii

Address chainge.

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2.newencoding.diff.gz

Add PsqlODBC and document ...etc patch.

Eiji Tokuya

#12Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#11)
Re: Added Encoding

Your patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

Eiji Tokuya wrote:

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2b2.newencoding.diff.tar.gz

(608K)

Looks good. I need some people to review this for me.

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

The diff is 3mb
but appears to address only additions to multibyte. I have attached a
list of files it modifies. Also, look at the sizes of the mb/
directory. It is getting large:

4 ./CVS
6 ./Unicode/CVS
3433 ./Unicode
6197 .

Yes. We definitely need the on-the-fly encoding addition capability:
i.e. CREATE CHRACTER SET in the future...
--
Tatsuo Ishii

Address chainge.

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2.newencoding.diff.gz

Add PsqlODBC and document ...etc patch.

Eiji Tokuya

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#13Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#11)
Re: Added Encoding

Your updated patch has been added to the PostgreSQL unapplied patches list at:

http://candle.pha.pa.us/cgi-bin/pgpatches

I will try to apply it within the next 48 hours.

---------------------------------------------------------------------------

-----Original Message-----
From: Bruce Momjian [mailto:pgman@candle.pha.pa.us]
Sent: Saturday, February 23, 2002 8:27 AM
To: Tatsuo Ishii
Cc: e-tokuya@sankyo-unyu.co.jp; pgsql-patches@postgresql.org
Subject: Re: [PATCHES] Added Encoding

Was this ever added? I can't find it.

------------------------------------------------------------------
---------

Tatsuo Ishii wrote:

It was made to cope with encoding such as an Asian bloc in 7.2Beta2.

Added ServerEncoding
Korean (JOHAB), Thai (WIN874),
Vietnamese (TCVN), Arabic (WIN1256)

Added ClientEncoding
Simplified Chinese (GBK), Korean (UHC)

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2b2.newencoding.diff.tar.gz

(608K)

Looks good. I need some people to review this for me.

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

The diff is 3mb
but appears to address only additions to multibyte. I have attached a
list of files it modifies. Also, look at the sizes of the mb/
directory. It is getting large:

4 ./CVS
6 ./Unicode/CVS
3433 ./Unicode
6197 .

Yes. We definitely need the on-the-fly encoding addition capability:
i.e. CREATE CHRACTER SET in the future...
--
Tatsuo Ishii

Address chainge.

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2.newencoding.diff.gz

Add PsqlODBC and document ...etc patch.

Eiji Tokuya

---------------------------(end of broadcast)---------------------------
TIP 6: Have you searched our list archives?

http://archives.postgresql.org

Eiji Tokuya wrote:
[ Charset Shift_JIS unsupported, skipping... ]

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#14Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#11)
Re: Added Encoding

Patch applied. Thanks.

---------------------------------------------------------------------------

Tatsuo Ishii wrote:

It was made to cope with encoding such as an Asian bloc in 7.2Beta2.

Added ServerEncoding
Korean (JOHAB), Thai (WIN874),
Vietnamese (TCVN), Arabic (WIN1256)

Added ClientEncoding
Simplified Chinese (GBK), Korean (UHC)

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2b2.newencoding.diff.tar.gz

(608K)

Looks good. I need some people to review this for me.

For me they look good too. The only missing part is a
documentation. I will ask him to write it up. If he couldn't, I will
do it for him.

The diff is 3mb
but appears to address only additions to multibyte. I have attached a
list of files it modifies. Also, look at the sizes of the mb/
directory. It is getting large:

4 ./CVS
6 ./Unicode/CVS
3433 ./Unicode
6197 .

Yes. We definitely need the on-the-fly encoding addition capability:
i.e. CREATE CHRACTER SET in the future...
--
Tatsuo Ishii

Address chainge.

http://www.sankyo-unyu.co.jp/Pool/postgresql-7.2.newencoding.diff.gz

Add PsqlODBC and document ...etc patch.

Eiji Tokuya

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#15Eiji Tokuya
e-tokuya@sankyo-unyu.co.jp
In reply to: Bruce Momjian (#14)
Re: Added Encoding

Hi Bruce

Toruble patch applied "Added Encoding".

But, some added files aren't registered.

src/backend/utils/mb/Unicode/utf8_to_gbk.map
src/backend/utils/mb/Unicode/utf8_to_johab.map
src/backend/utils/mb/Unicode/utf8_to_tcvn.map
src/backend/utils/mb/Unicode/utf8_to_uhc.map
src/backend/utils/mb/Unicode/utf8_to_win1256.map
src/backend/utils/mb/Unicode/utf8_to_win874.map
src/backend/utils/mb/Unicode/gbk_to_utf8.map
src/backend/utils/mb/Unicode/johab_to_utf8.map
src/backend/utils/mb/Unicode/tcvn_to_utf8.map
src/backend/utils/mb/Unicode/uhc_to_utf8.map
src/backend/utils/mb/Unicode/win874_to_utf8.map
src/backend/utils/mb/Unicode/UCS_to_GBK.pl
src/backend/utils/mb/Unicode/UCS_to_JOHAB.pl
src/backend/utils/mb/Unicode/UCS_to_UHC.pl
src/backend/utils/mb/Unicode/UCS_to_WIN874.pl

It is short of these files.

Eiji Tokuya

#16Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#15)
Re: Added Encoding

Eiji Tokuya wrote:
[ Charset Shift_JIS unsupported, skipping... ]

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#17Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#15)
Re: Added Encoding

Sorry, I will fix this hopefully tomorrow. Thanks.

Toruble patch applied "Added Encoding".

But, some added files aren't registered.

src/backend/utils/mb/Unicode/utf8_to_gbk.map
src/backend/utils/mb/Unicode/utf8_to_johab.map
src/backend/utils/mb/Unicode/utf8_to_tcvn.map
src/backend/utils/mb/Unicode/utf8_to_uhc.map
src/backend/utils/mb/Unicode/utf8_to_win1256.map
src/backend/utils/mb/Unicode/utf8_to_win874.map
src/backend/utils/mb/Unicode/gbk_to_utf8.map
src/backend/utils/mb/Unicode/johab_to_utf8.map
src/backend/utils/mb/Unicode/tcvn_to_utf8.map
src/backend/utils/mb/Unicode/uhc_to_utf8.map
src/backend/utils/mb/Unicode/win874_to_utf8.map
src/backend/utils/mb/Unicode/UCS_to_GBK.pl
src/backend/utils/mb/Unicode/UCS_to_JOHAB.pl
src/backend/utils/mb/Unicode/UCS_to_UHC.pl
src/backend/utils/mb/Unicode/UCS_to_WIN874.pl

It is short of these files.

Eiji Tokuya

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#18Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#15)
Re: Added Encoding

Eiji Tokuya wrote:
[ Charset Shift_JIS unsupported, skipping... ]

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#19Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#15)
Re: Added Encoding

Files added. Thanks.

Toruble patch applied "Added Encoding".

But, some added files aren't registered.

src/backend/utils/mb/Unicode/utf8_to_gbk.map
src/backend/utils/mb/Unicode/utf8_to_johab.map
src/backend/utils/mb/Unicode/utf8_to_tcvn.map
src/backend/utils/mb/Unicode/utf8_to_uhc.map
src/backend/utils/mb/Unicode/utf8_to_win1256.map
src/backend/utils/mb/Unicode/utf8_to_win874.map
src/backend/utils/mb/Unicode/gbk_to_utf8.map
src/backend/utils/mb/Unicode/johab_to_utf8.map
src/backend/utils/mb/Unicode/tcvn_to_utf8.map
src/backend/utils/mb/Unicode/uhc_to_utf8.map
src/backend/utils/mb/Unicode/win874_to_utf8.map
src/backend/utils/mb/Unicode/UCS_to_GBK.pl
src/backend/utils/mb/Unicode/UCS_to_JOHAB.pl
src/backend/utils/mb/Unicode/UCS_to_UHC.pl
src/backend/utils/mb/Unicode/UCS_to_WIN874.pl

It is short of these files.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 853-3000
  +  If your life is a hard drive,     |  830 Blythe Avenue
  +  Christ can be your backup.        |  Drexel Hill, Pennsylvania 19026
#20Eiji Tokuya
e-tokuya@sankyo-unyu.co.jp
In reply to: Bruce Momjian (#18)
Re: Added Encoding

Added ServerEncoding
Korean (JOHAB), Thai (WIN874),
Vietnamese (TCVN), Arabic (WIN1256)

Added ClientEncoding
Simplified Chinese (GBK), Korean (UHC)

Add PsqlODBC and document ...etc patch.

"JDBC patch" is delivered, too. :-)

Eiji Tokuya

Attachments:

postgresql-7.2-jdbc.newencoding.diff.gzapplication/x-tar; name=postgresql-7.2-jdbc.newencoding.diff.gzDownload+10-8
#21Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#20)
#22Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#20)
#23Bruce Momjian
bruce@momjian.us
In reply to: Eiji Tokuya (#20)