mingw regression test fixes

I'm assuming that you have checked that this works, as it is slightly
different from what I did.

Seems to.

Strictly speaking, the pwd flags test should probably depend
in the test
platform rather than the target platform. Something like:

case `uname` in
MINGW32*)
PWDFLAGS=-W;;
*)
PWDFLAGS=;;
esac

There's three other tests that use $host_platform in pg_regress.sh in the
exact same manner. Not sure I understand the objection.

Cheers,
Claudio

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

Claudio Natoli said:

For application to HEAD.

As Andrew Dunstan appears to have cracked the regression test buffering
nut, this patch makes sure that:
* correct platform specific regression files are used under ming
* pwd prints out a usable win32 pathname

Claudio,

I'm assuming that you have checked that this works, as it is slightly
different from what I did.

Strictly speaking, the pwd flags test should probably depend in the test
platform rather than the target platform. Something like:

case `uname` in
MINGW32*)
PWDFLAGS=-W;;
*)
PWDFLAGS=;;
esac

I made that adjustment to what I was doing late in the day, but didn't
have time to do a revised patch before I had to do other things.

cheers

andrew

Claudio Natoli said:

Strictly speaking, the pwd flags test should probably depend
in the test
platform rather than the target platform. Something like:

case `uname` in
MINGW32*)
PWDFLAGS=-W;;
*)
PWDFLAGS=;;
esac

There's three other tests that use $host_platform in pg_regress.sh in
the exact same manner. Not sure I understand the objection.

if you tested a mingw build from some other platform pwd might not
understand the -W flag. It's probably a minor nit at best.

cheers

andrew

Patch applied. Thanks.

---------------------------------------------------------------------------

Claudio Natoli wrote:

For application to HEAD.

As Andrew Dunstan appears to have cracked the regression test buffering nut,
this patch makes sure that:
* correct platform specific regression files are used under ming
* pwd prints out a usable win32 pathname

Cheers,
Claudio

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

[ Attachment, skipping... ]

---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

OK, I have made this adjustment. Thanks.

---------------------------------------------------------------------------

Andrew Dunstan wrote:

Claudio Natoli said:

For application to HEAD.

As Andrew Dunstan appears to have cracked the regression test buffering
nut, this patch makes sure that:
* correct platform specific regression files are used under ming
* pwd prints out a usable win32 pathname

Claudio,

I'm assuming that you have checked that this works, as it is slightly
different from what I did.

Strictly speaking, the pwd flags test should probably depend in the test
platform rather than the target platform. Something like:

case `uname` in
MINGW32*)
PWDFLAGS=-W;;
*)
PWDFLAGS=;;
esac

I made that adjustment to what I was doing late in the day, but didn't
have time to do a revised patch before I had to do other things.

cheers

andrew

---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Bruce Momjian wrote:

OK, I have made this adjustment. Thanks.

$build_platform would be more correct. It keeps everything consistent.

Peter Eisentraut wrote:

Bruce Momjian wrote:

OK, I have made this adjustment. Thanks.

$build_platform would be more correct. It keeps everything consistent.

OK, new code for PWD flag test is:

case $build_platform in
*-*-mingw32*)
PWDFLAGS=-W;;
*)
PWDFLAGS=;;
esac

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

Peter, did you mean $host_platform by any chance... as originally submitted?
I see no use of $build_platform anywhere, and as committed this plain fails.

I don't see why there is any need for discussion over this. There are 3
cases statements preceding this one, all of which use $host_platform. The
one immediately preceding it does the very same thing for DIFFFLAGS!

Although perhaps this was the point you were trying to make, and Bruce took
you a little too literally?

Cheers,
Claudio

-----Original Message-----
From: Peter Eisentraut [mailto:peter_e@gmx.net]
Sent: Monday, 3 May 2004 6:18 AM
To: Bruce Momjian; Andrew Dunstan
Cc: claudio.natoli@memetrics.com; pgsql-patches@postgresql.org
Subject: Re: [PATCHES] mingw regression test fixes

Bruce Momjian wrote:

OK, I have made this adjustment. Thanks.

$build_platform would be more correct. It keeps everything
consistent.

---------------------------------------------------------------------

------

Andrew Dunstan wrote:

Claudio Natoli said:

For application to HEAD.

As Andrew Dunstan appears to have cracked the regression test
buffering nut, this patch makes sure that:
* correct platform specific regression files are used under ming
* pwd prints out a usable win32 pathname

Claudio,

I'm assuming that you have checked that this works, as it is
slightly different from what I did.

Strictly speaking, the pwd flags test should probably

depend in the

test platform rather than the target platform. Something like:

case `uname` in
MINGW32*)
PWDFLAGS=-W;;
*)
PWDFLAGS=;;
esac

I made that adjustment to what I was doing late in the day, but
didn't have time to do a revised patch before I had to do other
things.

cheers

andrew

---------------------------(end of
broadcast)--------------------------- TIP 7: don't forget to
increase your free space map settings

--- 
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see 
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

Claudio Natoli wrote:

Peter, did you mean $host_platform by any chance... as originally
submitted? I see no use of $build_platform anywhere, and as committed
this plain fails.

I meant that $build_platform would be better than `uname`, not that my
word is to be taken blindly without testing. But...

I don't see why there is any need for discussion over this. There are
3 cases statements preceding this one, all of which use
$host_platform. The one immediately preceding it does the very same
thing for DIFFFLAGS!

... that is a very good argument for $host_platform as originally
proposed.

Peter Eisentraut wrote:

Claudio Natoli wrote:

Peter, did you mean $host_platform by any chance... as originally
submitted? I see no use of $build_platform anywhere, and as committed
this plain fails.

I meant that $build_platform would be better than `uname`, not that my
word is to be taken blindly without testing. But...

I don't see why there is any need for discussion over this. There are
3 cases statements preceding this one, all of which use
$host_platform. The one immediately preceding it does the very same
thing for DIFFFLAGS!

... that is a very good argument for $host_platform as originally
proposed.

OK, new code, back to original. :-)

case $host_platform in
*-*-mingw32*)
PWDFLAGS=-W;;
*)
PWDFLAGS=;;
esac

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman@candle.pha.pa.us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073