re-enable MSVC builds

Andrew Dunstan <andrew@dunslane.net> writes:

The attached patch allows MSCV builds to complete.

Applied.

(I wonder whether the Borland build still works...)

The warnings still shown (see recent -hackers email) are identical to
those that were present in RC2, so they are not the products of recent
homedir changes.

With the possible exception of the mkdir warning, these seem cosmetic
and not worth worrying about at this stage of the release cycle.

regards, tom lane

The attached patch allows MSCV builds to complete.

Applied.

(I wonder whether the Borland build still works...)

I'm sure it still eneds the shell32 linking. The suorce part should be
the same - AFAIK they ship the MS headers. But I don't have a way to
test it, so...

The warnings still shown (see recent -hackers email) are

identical to

those that were present in RC2, so they are not the

products of recent

homedir changes.

With the possible exception of the mkdir warning, these seem
cosmetic and not worth worrying about at this stage of the
release cycle.

Definitly. There have been cosmetic warnings in the win32 build ever
since it was created.

//Magnus

Magnus Hagander wrote:

The attached patch allows MSCV builds to complete.

Applied.

(I wonder whether the Borland build still works...)

I'm sure it still eneds the shell32 linking. The suorce part should be
the same - AFAIK they ship the MS headers. But I don't have a way to
test it, so...

Me either, and I don't have time to acquire/test before release. I don't
see where to put it in the bcc.mak file anyway. So, either it's not
broken, or it is broken and will stay that way, or it is broken and
somebody else will step in *real* quick to fix it :-) I am not betting
on this last.

cheers

andrew

Andrew Dunstan <andrew@dunslane.net> writes:

Magnus Hagander wrote:

I'm sure it still eneds the shell32 linking.

I don't see where to put it in the bcc.mak file anyway.

Yeah, I looked in bcc32.mak and didn't see any reference to the other
*32.dll files that win32.mak references. So either Borland does not
need any of them, or the Borland build has been broken for awhile.

If someone steps up to fix it, great, otherwise it's on the path to
extinction...

regards, tom lane