Re: 300 seconds in less than 1 second with pg_autovacuum
-----Original Message-----
From: pgsql-hackers-win32-owner@postgresql.org
[mailto:pgsql-hackers-win32-owner@postgresql.org] On Behalf
Of Dave Page
Sent: 21 January 2005 13:20
To: Harald Massa; pgsql-hackers-win32@postgresql.org
Subject: Re: [pgsql-hackers-win32] 300 seconds in less than 1
second with pg_autovacuum-----Original Message-----
From: pgsql-hackers-win32-owner@postgresql.org
[mailto:pgsql-hackers-win32-owner@postgresql.org] On Behalf
Of Harald Massa
Sent: 21 January 2005 12:55
To: pgsql-hackers-win32@postgresql.org
Subject: [pgsql-hackers-win32] 300 seconds in less than 1
second with pg_autovacuumWhat is going wrong? I did not fiddle with the
"Sleep-Period", just left it
on default.Hmm:
Windows:
VOID Sleep(DWORD dwMilliseconds);
Unix:
unsigned int sleep(unsigned int seconds);
D'oh!
Patch coming up....
Patch attached... Harald, do you want another exe to try?
Regards, Dave
Attachments:
pg_autovacuum.c.diffapplication/octet-stream; name=pg_autovacuum.c.diffDownload+5-1
Dave Page said:
Hmm:
Windows:
VOID Sleep(DWORD dwMilliseconds);
Unix:
unsigned int sleep(unsigned int seconds);
D'oh!
Patch coming up....
We should not be using either of these, should we? pg_usleep() is platform
independent.
cheers
andrew
-----Original Message-----
From: Andrew Dunstan [mailto:andrew@dunslane.net]
Sent: 21 January 2005 14:01
To: Dave Page
Cc: ghum@gmx.net; pgsql-hackers-win32@postgresql.org;
pgsql-patches@postgresql.org
Subject: Re: [PATCHES] [pgsql-hackers-win32] 300 seconds in
less than 1 second with pg_autovacuumWe should not be using either of these, should we?
pg_usleep() is platform
independent.
True. Attached.
Regards, Dave.
Attachments:
pg_autovacuum.c.diffapplication/octet-stream; name=pg_autovacuum.c.diffDownload+1-1
Import Notes
Resolved by subject fallback
[ Previous sleep() patch removed.]
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---------------------------------------------------------------------------
Dave Page wrote:
-----Original Message-----
From: Andrew Dunstan [mailto:andrew@dunslane.net]
Sent: 21 January 2005 14:01
To: Dave Page
Cc: ghum@gmx.net; pgsql-hackers-win32@postgresql.org;
pgsql-patches@postgresql.org
Subject: Re: [PATCHES] [pgsql-hackers-win32] 300 seconds in
less than 1 second with pg_autovacuumWe should not be using either of these, should we?
pg_usleep() is platform
independent.True. Attached.
Regards, Dave.
Content-Description: pg_autovacuum.c.diff
[ Attachment, skipping... ]
---------------------------(end of broadcast)---------------------------
TIP 2: you can get off all lists at once with the unregister command
(send "unregister YourEmailAddressHere" to majordomo@postgresql.org)
--
Bruce Momjian | http://candle.pha.pa.us
pgman@candle.pha.pa.us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073