plperl tests for currently untested features
continuing my quest for better testing ... ;-)
The current plperl regression tests do not test the trigger or shared
data features. The attached new files remedy that:
sql/plperl_trigger.sql
sql/plperl_shared.sql
expected/plperl_trigger.out
expected/plperl_shared.out
The corresponding patch for GNUmakefile is below
Is it worth supplying a more descriptive name to the current plperl.sql
test script?
cheers
andrew
Index: GNUmakefile
===================================================================
RCS file: /projects/cvsroot/pgsql/src/pl/plperl/GNUmakefile,v
retrieving revision 1.20
diff -c -r1.20 GNUmakefile
*** GNUmakefile 17 May 2005 18:26:22 -0000 1.20
--- GNUmakefile 23 May 2005 22:08:07 -0000
***************
*** 37,43 ****
SHLIB_LINK = $(perl_embed_ldflags) $(BE_DLLLIBS) REGRESS_OPTS = --dbname=$(PL_TESTDB) --load-language=plperl
! REGRESS = plperl
include $(top_srcdir)/src/Makefile.shlib
--- 37,43 ----
SHLIB_LINK = $(perl_embed_ldflags) $(BE_DLLLIBS) REGRESS_OPTS = --dbname=$(PL_TESTDB) --load-language=plperl
! REGRESS = plperl plperl_trigger plperl_shared
include $(top_srcdir)/src/Makefile.shlib
Andrew Dunstan wrote:
The current plperl regression tests do not test the trigger or shared
data features. The attached new files remedy that [...]
Barring any objections I'll apply this later today.
-Neil
Andrew Dunstan wrote:
The current plperl regression tests do not test the trigger or shared
data features. The attached new files remedy that [...]
Applied to HEAD. Thanks for the patch.
BTW, I noticed that the PL/Perl regression tests are broken for out of
tree build (i.e. "vpath")...
-Neil
Neil Conway wrote:
Andrew Dunstan wrote:
The current plperl regression tests do not test the trigger or shared
data features. The attached new files remedy that [...]Applied to HEAD. Thanks for the patch.
BTW, I noticed that the PL/Perl regression tests are broken for out of
tree build (i.e. "vpath")...
I see that in fact all the PL tests are broken for vpath builds.
Did they work before we moved them to the pg_regress mechanism?
I am not a vpath master, so if someone can suggest a neat fix I'd be
grateful.
cheers
andrew
Andrew Dunstan <andrew@dunslane.net> writes:
Neil Conway wrote:
BTW, I noticed that the PL/Perl regression tests are broken for out of
tree build (i.e. "vpath")...
I see that in fact all the PL tests are broken for vpath builds.
Fixed (copy and paste from src/test/regress) --- I can't actually
test the plpython script right now, but it should work the same
as the other two.
regards, tom lane
Tom Lane wrote:
I see that in fact all the PL tests are broken for vpath builds.
Fixed (copy and paste from src/test/regress) --- I can't actually
test the plpython script right now, but it should work the same
as the other two.
Thanks. I have added support for vpath builds to the list of features
wanted on the buildfarm.
cheers
andrew