pre-vcbuild win32 install docs incorrect

Started by Magnus Haganderover 19 years ago8 messagespatches
Jump to latest
#1Magnus Hagander
magnus@hagander.net

This patch fixes a really bad recommendation that's not been removed
from the client-only installation instructions. We removed this
recommendation as of 8.1, but it's still included in the documentation :-(

Please consider back-patching this into the 8.1 and 8.2 version of the
documentation, as it's something we really don't want people to do.

I came across this while looking at how to update that documentation to
deal with the new VC++ build stuff. I can't quite decide on how to do
that yet - do people have any strong opinions on if the new vcbuild
stuff should go in the documentation proper, or stay in
src/tools/msvc/README?

//Magnus

Attachments:

instwin32doc.patchtext/plain; name=instwin32doc.patchDownload+9-9
#2Neil Conway
neilc@samurai.com
In reply to: Magnus Hagander (#1)
Re: pre-vcbuild win32 install docs incorrect

On Fri, 2007-02-02 at 10:12 +0100, Magnus Hagander wrote:

This patch fixes a really bad recommendation that's not been removed
from the client-only installation instructions. We removed this
recommendation as of 8.1, but it's still included in the documentation :-(

Please consider back-patching this into the 8.1 and 8.2 version of the
documentation, as it's something we really don't want people to do.

I backpatched this to 8.0, since that branch still has the suggestion.
Thanks for the patch.

*** doc\src\sgml/install-win32.sgml	16 Sep 2006 00:30:14 -0000	1.29
--- doc\src\sgml/install-win32.sgml	2 Feb 2007 09:07:48 -0000

Please don't do this :)

-Neil

#3Magnus Hagander
magnus@hagander.net
In reply to: Neil Conway (#2)
Re: pre-vcbuild win32 install docs incorrect

Neil Conway wrote:

On Fri, 2007-02-02 at 10:12 +0100, Magnus Hagander wrote:

This patch fixes a really bad recommendation that's not been removed
from the client-only installation instructions. We removed this
recommendation as of 8.1, but it's still included in the documentation :-(

Please consider back-patching this into the 8.1 and 8.2 version of the
documentation, as it's something we really don't want people to do.

I backpatched this to 8.0, since that branch still has the suggestion.
Thanks for the patch.

Thanks.

*** doc\src\sgml/install-win32.sgml	16 Sep 2006 00:30:14 -0000	1.29
--- doc\src\sgml/install-win32.sgml	2 Feb 2007 09:07:48 -0000

Please don't do this :)

You know, I wish I didn't have to ;-) Unfortunately, the only way for me
to create a patch offline (like this one, on an airplane) is to rsync
the cvs repository down to the local drive, and run cvsnt on it - since
cvs does not support offline diff. And the only way to make it not put
in backslashes instead of slashes is do run the diff in the docs
directory and not in the root :-(

Does this actually cause a problem for you when you're committing, or is
is just that it looks bad? Because if it causes a problem I can manually
edit them out of my patches before I submit.

//Magnus

#4Bruce Momjian
bruce@momjian.us
In reply to: Magnus Hagander (#3)
Re: pre-vcbuild win32 install docs incorrect

Magnus Hagander wrote:

Neil Conway wrote:

On Fri, 2007-02-02 at 10:12 +0100, Magnus Hagander wrote:

This patch fixes a really bad recommendation that's not been removed
from the client-only installation instructions. We removed this
recommendation as of 8.1, but it's still included in the documentation :-(

Please consider back-patching this into the 8.1 and 8.2 version of the
documentation, as it's something we really don't want people to do.

I backpatched this to 8.0, since that branch still has the suggestion.
Thanks for the patch.

Thanks.

*** doc\src\sgml/install-win32.sgml	16 Sep 2006 00:30:14 -0000	1.29
--- doc\src\sgml/install-win32.sgml	2 Feb 2007 09:07:48 -0000

Please don't do this :)

You know, I wish I didn't have to ;-) Unfortunately, the only way for me
to create a patch offline (like this one, on an airplane) is to rsync
the cvs repository down to the local drive, and run cvsnt on it - since
cvs does not support offline diff. And the only way to make it not put
in backslashes instead of slashes is do run the diff in the docs
directory and not in the root :-(

Does this actually cause a problem for you when you're committing, or is
is just that it looks bad? Because if it causes a problem I can manually
edit them out of my patches before I submit.

It causes patch application problems, but I just edit the patchfile to
fix it. I could get fancy and have my patch script fix it too.

--
Bruce Momjian bruce@momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

#5Magnus Hagander
magnus@hagander.net
In reply to: Bruce Momjian (#4)
Re: pre-vcbuild win32 install docs incorrect
*** doc\src\sgml/install-win32.sgml	16 Sep 2006 00:30:14 -0000	1.29
--- doc\src\sgml/install-win32.sgml	2 Feb 2007 09:07:48 -0000

Please don't do this :)

You know, I wish I didn't have to ;-) Unfortunately, the only way for me
to create a patch offline (like this one, on an airplane) is to rsync
the cvs repository down to the local drive, and run cvsnt on it - since
cvs does not support offline diff. And the only way to make it not put
in backslashes instead of slashes is do run the diff in the docs
directory and not in the root :-(

Does this actually cause a problem for you when you're committing, or is
is just that it looks bad? Because if it causes a problem I can manually
edit them out of my patches before I submit.

It causes patch application problems, but I just edit the patchfile to
fix it. I could get fancy and have my patch script fix it too.

I was not aware it did. My apologies for keeping to send broken patches
then :-O I will try to remember to edit the paths before I submit from
this machine in the future.

//Magnus

#6Andrew Dunstan
andrew@dunslane.net
In reply to: Magnus Hagander (#3)
Re: pre-vcbuild win32 install docs incorrect

Magnus Hagander wrote:

*** doc\src\sgml/install-win32.sgml	16 Sep 2006 00:30:14 -0000	1.29
--- doc\src\sgml/install-win32.sgml	2 Feb 2007 09:07:48 -0000

Please don't do this :)

You know, I wish I didn't have to ;-) Unfortunately, the only way for me
to create a patch offline (like this one, on an airplane) is to rsync
the cvs repository down to the local drive, and run cvsnt on it - since
cvs does not support offline diff. And the only way to make it not put
in backslashes instead of slashes is do run the diff in the docs
directory and not in the root :-(

I'm not sure what offline has to do with it. Having a braindead client
that you can't tell to use forward slashes seems more like the cause.
CVS clients for Cygwin or MSys don't have this defect, that I know of.

cheers

andrew

#7Magnus Hagander
magnus@hagander.net
In reply to: Andrew Dunstan (#6)
Re: pre-vcbuild win32 install docs incorrect

Andrew Dunstan wrote:

Magnus Hagander wrote:

*** doc\src\sgml/install-win32.sgml    16 Sep 2006 00:30:14 -0000   
1.29
--- doc\src\sgml/install-win32.sgml    2 Feb 2007 09:07:48 -0000

Please don't do this :)

You know, I wish I didn't have to ;-) Unfortunately, the only way for me
to create a patch offline (like this one, on an airplane) is to rsync
the cvs repository down to the local drive, and run cvsnt on it - since
cvs does not support offline diff. And the only way to make it not put
in backslashes instead of slashes is do run the diff in the docs
directory and not in the root :-(

I'm not sure what offline has to do with it. Having a braindead client
that you can't tell to use forward slashes seems more like the cause.
CVS clients for Cygwin or MSys don't have this defect, that I know of.

My cvs client only has this problem when it's talking to a local
filesystem cvs repository, not when talking to anoncvs.

//Magnus

#8Andrew Dunstan
andrew@dunslane.net
In reply to: Magnus Hagander (#7)
Re: pre-vcbuild win32 install docs incorrect

Magnus Hagander wrote:

I'm not sure what offline has to do with it. Having a braindead client
that you can't tell to use forward slashes seems more like the cause.
CVS clients for Cygwin or MSys don't have this defect, that I know of.

My cvs client only has this problem when it's talking to a local
filesystem cvs repository, not when talking to anoncvs.

Maybe you need to run a local pserver then.

cheers

andrew