Improve readability of if-statement in dmetaphone.c
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
This thread has been committed, so CI has stopped here. Anything below is the last result it produced.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t253301psql -h localhost -U postgresBuilt from patchset v1 (message #1), August 03, 2026 at 10:58 PM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t253301_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t253301_1 && git checkout t253301_1Patchset v1 (message #1) is on t253301_1
clangd was warning on the indentation of the else-if statement with
a readability-misleading-indentation. I'll agree with clangd in this
instance. I had to stare at the block for a moment to understand what it
was doing. Figured I would throw the patch up in the event some
committer agreed.
--
Tristan Partin
PostgreSQL Contributors Team
AWS (https://aws.amazon.com)
On 4 Aug 2026, at 00:45, Tristan Partin <tristan@partin.io> wrote:
clangd was warning on the indentation of the else-if statement with
a readability-misleading-indentation. I'll agree with clangd in this
instance. I had to stare at the block for a moment to understand what it
was doing. Figured I would throw the patch up in the event some
committer agreed.
That is indeed a much better way to format the conditional, will fix.
--
Daniel Gustafsson