pgsql: pg_basebackup -F t now succeeds with a long symlink target

Started by Andrew Dunstanover 10 years ago3 messages
#1Andrew Dunstan
andrew@dunslane.net

pg_basebackup -F t now succeeds with a long symlink target

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/97e0aa697983cf7f7f79e69f2dc248fdefb7dbf6

Modified Files
--------------
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers

#2Alvaro Herrera
alvherre@2ndquadrant.com
In reply to: Andrew Dunstan (#1)
Re: [COMMITTERS] pgsql: pg_basebackup -F t now succeeds with a long symlink target

You have a memory error in this patch -- clobbered by pfree:

Details
-------
http://git.postgresql.org/pg/commitdiff/97e0aa697983cf7f7f79e69f2dc248fdefb7dbf6

^^^^ here

Sorry, couldn't resist.

--
�lvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Amit Kapila
amit.kapila16@gmail.com
In reply to: Alvaro Herrera (#2)
Re: Re: [COMMITTERS] pgsql: pg_basebackup -F t now succeeds with a long symlink target

On Tue, May 12, 2015 at 10:51 PM, Alvaro Herrera <alvherre@2ndquadrant.com>
wrote:

You have a memory error in this patch -- clobbered by pfree:

Details
-------

http://git.postgresql.org/pg/commitdiff/97e0aa697983cf7f7f79e69f2dc248fdefb7dbf6

^^^^ here

If we want to support long symlink targets, then shouldn't we
first tackle the changes done in commit-23a78352 ?

With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com