Mail thread references in commits
I love seeing references to email threads in commit messages. It would
make them a lot friendlier though if a full http URL were included
instead of just a Message-ID, i.e. instead of <foo1234@bar.com> put
</messages/by-id/foo1234@bar.com>. I know this is
a bit more trouble. but not that much, and it would make it very easy to
follow with just a mouse click.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On November 17, 2016 1:02:38 PM PST, Andrew Dunstan <andrew@dunslane.net> wrote:
I love seeing references to email threads in commit messages. It would
make them a lot friendlier though if a full http URL were included
instead of just a Message-ID, i.e. instead of <foo1234@bar.com> put
</messages/by-id/foo1234@bar.com>. I know this isa bit more trouble. but not that much, and it would make it very easy
to
follow with just a mouse click.
They're really hard to read though, because lines with e.g. gmail message IDs get very long even without that prefix. Do you look at these in the e-mail or gitweb?
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Nov 17, 2016 at 4:06 PM, Andres Freund <andres@anarazel.de> wrote:
On November 17, 2016 1:02:38 PM PST, Andrew Dunstan <andrew@dunslane.net> wrote:
I love seeing references to email threads in commit messages. It would
make them a lot friendlier though if a full http URL were included
instead of just a Message-ID, i.e. instead of <foo1234@bar.com> put
</messages/by-id/foo1234@bar.com>. I know this isa bit more trouble. but not that much, and it would make it very easy
to
follow with just a mouse click.They're really hard to read though, because lines with e.g. gmail message IDs get very long even without that prefix. Do you look at these in the e-mail or gitweb?
Yeah. I really hate having commit messages that are more than 70-75
characters wide, and a message-ID takes you well above that. I wish
we had something like archives.postgresql.org/sha/5bcd5142 instead of
basing everything off the message-ID.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Andrew Dunstan wrote:
I love seeing references to email threads in commit messages. It would make
them a lot friendlier though if a full http URL were included instead of
just a Message-ID, i.e. instead of <foo1234@bar.com> put
</messages/by-id/foo1234@bar.com>. I know this is a
bit more trouble. but not that much, and it would make it very easy to
follow with just a mouse click.
I completely agree. I would favor something even more convenient, such
as
/messages/by-id/foo1234@bar.com
which just redirects to the full URL. That saves a decent number of
chars.
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Robert Haas wrote:
On Thu, Nov 17, 2016 at 4:06 PM, Andres Freund <andres@anarazel.de> wrote:
On November 17, 2016 1:02:38 PM PST, Andrew Dunstan <andrew@dunslane.net> wrote:
I love seeing references to email threads in commit messages. It would
make them a lot friendlier though if a full http URL were included
instead of just a Message-ID, i.e. instead of <foo1234@bar.com> put
</messages/by-id/foo1234@bar.com>. I know this isa bit more trouble. but not that much, and it would make it very easy
to
follow with just a mouse click.They're really hard to read though, because lines with e.g. gmail message IDs get very long even without that prefix. Do you look at these in the e-mail or gitweb?
Yeah. I really hate having commit messages that are more than 70-75
characters wide, and a message-ID takes you well above that. I wish
we had something like archives.postgresql.org/sha/5bcd5142 instead of
basing everything off the message-ID.
The advantage of using the message-ID is that you can use it while
offline too (very common among this crowd to do stuff while on planes,
since conferences and such are so frequent now), so I wouldn't make that
trade.
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Andrew Dunstan <andrew@dunslane.net> writes:
I love seeing references to email threads in commit messages. It would
make them a lot friendlier though if a full http URL were included
instead of just a Message-ID,
I've intentionally not done that, because it does not seem very
future-proof. The message ids will hopefully be unique indefinitely far
into the future, but the location of our archives could move.
Andres' point about line length is also an issue.
FWIW, I have my home page set up so that I can paste in a message ID and
go directly to the archived thread; there's more than one way to skin
that cat.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 11/17/2016 04:06 PM, Andres Freund wrote:
On November 17, 2016 1:02:38 PM PST, Andrew Dunstan <andrew@dunslane.net> wrote:
I love seeing references to email threads in commit messages. It would
make them a lot friendlier though if a full http URL were included
instead of just a Message-ID, i.e. instead of <foo1234@bar.com> put
</messages/by-id/foo1234@bar.com>. I know this isa bit more trouble. but not that much, and it would make it very easy
to
follow with just a mouse click.They're really hard to read though, because lines with e.g. gmail message IDs get very long even without that prefix. Do you look at these in the e-mail or gitweb?
Mainly in Thunderbird. But it's cumbersome either way.
I agree gmail message IDs are ugly and insanely long. Personally I would
rather pay the price of one line of ugliness for nice clickability.
To Tom's point that the URL might be ephemeral while the Message-ID is
not, the URL would contain the Message-ID, so even if the base changed
you could adjust to it.
cheers
andrew
**
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Tom Lane wrote:
Andrew Dunstan <andrew@dunslane.net> writes:
I love seeing references to email threads in commit messages. It would
make them a lot friendlier though if a full http URL were included
instead of just a Message-ID,I've intentionally not done that, because it does not seem very
future-proof. The message ids will hopefully be unique indefinitely far
into the future, but the location of our archives could move.
It won't. We have far too many in the archives to risk breaking them.
In fact, we (Magnus) went great lengths to implement a system so that
old-style PHP links (of which we have a bunch in very old archives,
including in commit messages) continue to work to this day. We're far
too invested in the system now, because of how successful it has proved
to be.
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Why not hash the URL? Something like:
Http://postgresopen.org/archive/743257890976432
Where the hash is derived from the message if?
Show quoted text
On Nov 17, 2016 17:40, "Alvaro Herrera" <alvherre@2ndquadrant.com> wrote:
Tom Lane wrote:
Andrew Dunstan <andrew@dunslane.net> writes:
I love seeing references to email threads in commit messages. It would
make them a lot friendlier though if a full http URL were included
instead of just a Message-ID,I've intentionally not done that, because it does not seem very
future-proof. The message ids will hopefully be unique indefinitely far
into the future, but the location of our archives could move.It won't. We have far too many in the archives to risk breaking them.
In fact, we (Magnus) went great lengths to implement a system so that
old-style PHP links (of which we have a bunch in very old archives,
including in commit messages) continue to work to this day. We're far
too invested in the system now, because of how successful it has proved
to be.--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Nov 18, 2016 at 1:38 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
Tom Lane wrote:
Andrew Dunstan <andrew@dunslane.net> writes:
I love seeing references to email threads in commit messages. It would
make them a lot friendlier though if a full http URL were included
instead of just a Message-ID,I've intentionally not done that, because it does not seem very
future-proof. The message ids will hopefully be unique indefinitely far
into the future, but the location of our archives could move.It won't. We have far too many in the archives to risk breaking them.
In fact, we (Magnus) went great lengths to implement a system so that
old-style PHP links (of which we have a bunch in very old archives,
including in commit messages) continue to work to this day. We're far
too invested in the system now, because of how successful it has proved
to be.
Right - we go out of our way to ensure we don't break URLs. That's why
anoncvs.postgresql.org is still actively maintained for example.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Thu, Nov 17, 2016 at 10:43 PM, Joshua Drake <jd@commandprompt.com> wrote:
Why not hash the URL? Something like:
Http://postgresopen.org/archive/743257890976432
I suggested that upthread...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Sorry didn't see it.
On Nov 18, 2016 12:44, "Robert Haas" <robertmhaas@gmail.com> wrote:
Show quoted text
On Thu, Nov 17, 2016 at 10:43 PM, Joshua Drake <jd@commandprompt.com>
wrote:Why not hash the URL? Something like:
Http://postgresopen.org/archive/743257890976432
I suggested that upthread...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Robert Haas <robertmhaas@gmail.com> writes:
On Thu, Nov 17, 2016 at 10:43 PM, Joshua Drake <jd@commandprompt.com> wrote:
Why not hash the URL? Something like:
Http://postgresopen.org/archive/743257890976432
I suggested that upthread...
Don't like the hashing idea because that would be useless for searching,
eg, one's own local mail archives. Also, if you are looking at a message
in your own mail store when composing a commit message (which I generally
am, don't know about other committers) how are you going to get the hash?
I think it's important to have the message-ID in cleartext.
AFAICS the proposal here is to go from, eg,
Discussion: <CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ@mail.gmail.com>
to
Discussion: /messages/by-id/CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ@mail.gmail.com
which is annoying, but the line was overlength already. Maybe we could
drop the Discussion: prefix and just write a URL:
/messages/by-id/CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ@mail.gmail.com
That's still overlength for gmail message-IDs, though, so I'm not sure
it's worth losing the label for.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Tom Lane wrote:
AFAICS the proposal here is to go from, eg,
Discussion: <CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ@mail.gmail.com>
to
Discussion: /messages/by-id/CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ@mail.gmail.com
which is annoying, but the line was overlength already. Maybe we could
drop the Discussion: prefix and just write a URL:/messages/by-id/CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ@mail.gmail.com
If we use our existing URL shortener, as I proposed upthread, it's still
overlength but decent enough:
/messages/by-id/CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ@mail.gmail.com
I was pretty sure I had proposed this previously and was surprised that
I couldn't find it in the archives anywhere; and sure enough, what I did
was post the idea to sysadmins@postgresql.org (over a year ago) so it
wasn't publicly visible. Anyway, I think the shortener is worth using
(and we can certainly spare the namespace).
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Nov 18, 2016 at 11:08 PM, Alvaro Herrera <alvherre@2ndquadrant.com>
wrote:
Tom Lane wrote:
AFAICS the proposal here is to go from, eg,
Discussion: <CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8Zd
whHT88LQ@mail.gmail.com>
to
Discussion: /messages/by-id/CAF4Au4w6rrH_
j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ@mail.gmail.com
which is annoying, but the line was overlength already. Maybe we could
drop the Discussion: prefix and just write a URL:j1bvVhzpOsRiHCog7sGJ3LSX0tY8ZdwhHT88LQ@mail.gmail.com
If we use our existing URL shortener, as I proposed upthread, it's still
overlength but decent enough:/messages/by-id/CAF4Au4w6rrH_j1bvVhzpOsRiHCog7sGJ3LSX0tY8Zd
whHT88LQ@mail.gmail.com
It does cut it down a bit. And doing it that way would certainly make it
very "long term survivable". If we put a hash in there, we have to store
the hash somewhere. Not that this is hard, but if there is concern about
long-termability.
Another option would be to teach the URL shortener about our messages
specifically, and just use an internal surrogate key we already have for
them. That way it could be something like the current Planet URLs (which
can be for example http://postgr.es/p/3Dl), so much shorter. To post one
people would have to go to a webform and paste in the messageid or existing
URL though -- or we could put a link on the page in the archives.
It would make the URLs actually short, but as mentioned upthread, that
wouldn't work at all if offline. So it'd be a tradeoff between those, but
so are pretty much all other options that don't include the full message-id.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
Magnus,
* Magnus Hagander (magnus@hagander.net) wrote:
It would make the URLs actually short, but as mentioned upthread, that
wouldn't work at all if offline. So it'd be a tradeoff between those, but
so are pretty much all other options that don't include the full message-id.
This is a bit of a crazy idea, but in the new list system, couldn't we
add a header which includes "our" surrogate message-id? Or possibly the
entire URL to the message, and maybe the URL for the entire thread?
Thanks!
Stephen
On 11/18/16 4:35 PM, Magnus Hagander wrote:
Another option would be to teach the URL shortener about our messages
specifically, and just use an internal surrogate key we already have for
them. That way it could be something like the current Planet URLs (which
can be for example http://postgr.es/p/3Dl), so much shorter. To post one
people would have to go to a webform and paste in the messageid or
existing URL though -- or we could put a link on the page in the archives.It would make the URLs actually short, but as mentioned upthread, that
wouldn't work at all if offline. So it'd be a tradeoff between those,
but so are pretty much all other options that don't include the full
message-id.
Would it be possible to stick that surrogate key into outgoing list
messages as an X- header?
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On 11/18/2016 07:07 PM, Stephen Frost wrote:
Magnus,
* Magnus Hagander (magnus@hagander.net) wrote:
It would make the URLs actually short, but as mentioned upthread, that
wouldn't work at all if offline. So it'd be a tradeoff between those, but
so are pretty much all other options that don't include the full message-id.This is a bit of a crazy idea, but in the new list system, couldn't we
add a header which includes "our" surrogate message-id? Or possibly the
entire URL to the message, and maybe the URL for the entire thread?
I had similar ideas.
cheers
andrew
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On November 18, 2016 1:06:18 PM PST, Tom Lane <tgl@sss.pgh.pa.us> wrote:
Robert Haas <robertmhaas@gmail.com> writes:
On Thu, Nov 17, 2016 at 10:43 PM, Joshua Drake <jd@commandprompt.com>
wrote:
Why not hash the URL? Something like:
Http://postgresopen.org/archive/743257890976432I suggested that upthread...
Don't like the hashing idea because that would be useless for
searching,
eg, one's own local mail archives. Also, if you are looking at a
message
in your own mail store when composing a commit message (which I
generally
am, don't know about other committers) how are you going to get the
hash?
I think it's important to have the message-ID in cleartext.
I do ask of that offline or at least locally. So I won't use something that makes that uncomfortable.
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
On Fri, Nov 18, 2016 at 6:05 PM, Andres Freund <andres@anarazel.de> wrote:
I do ask of that offline or at least locally. So I won't use something that makes that uncomfortable.
No committer here. But I do search for mails using the discussion ID
present in the log message by querying in my local mail box copy on a
more or less daily basis. So having a hash will clearly reduce the
flexibility of how things are possible today.
--
Michael
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
