Participants
Tatsuo Ishii
Tatsuo Ishii
Yugo Nagata
Yugo Nagata
Amit Kapila
Amit Kapila
Attachments
Download Latest Patchset
+2-2
Show all attachments
Thread Outline
#1...#2
Yugo NagataTatsuo Ishii
▸
Jan 20, 2017
#1Yugo NagataYugo Nagata
Jan 20, 2017
#2Tatsuo Ishii↳Tatsuo Ishiito Yugo Nagata (#1)
Jan 23, 2017
#3Amit Kapila↳Amit Kapilato Tatsuo Ishii (#2)
Jan 23, 2017
#4Tatsuo Ishii↳Tatsuo Ishiito Tatsuo Ishii (#2)
Jan 24, 2017

Fix a comment in feelist.c

Started by Yugo Nagataabout 9 years ago4 messageshackers
Jump to latest
#1Yugo Nagata
Yugo Nagata
nagata@sraoss.co.jp

Hi,

I've found a mistake in a comment of StrategyNotifyBgWriter
in freelist.c. bgwriterLatch was replaced by bgwprocno in
the following commit, but this is remained in the comment.

commit d72731a70450b5e7084991b9caa15cb58a2820df
Author: Andres Freund <andres@anarazel.de>
Date: Thu Dec 25 18:24:20 2014 +0100

Lockless StrategyGetBuffer clock sweep hot path.

Attached a patch.

--
Yugo Nagata <nagata@sraoss.co.jp>

Attachments:

fix_freelist_comment.patchtext/x-diff; name=fix_freelist_comment.patchDownload+2-2
#2Tatsuo Ishii
Tatsuo Ishii
t-ishii@sra.co.jp
In reply to: Yugo Nagata (#1)
Re: Fix a comment in feelist.c

I've found a mistake in a comment of StrategyNotifyBgWriter
in freelist.c. bgwriterLatch was replaced by bgwprocno in
the following commit, but this is remained in the comment.

commit d72731a70450b5e7084991b9caa15cb58a2820df
Author: Andres Freund <andres@anarazel.de>
Date: Thu Dec 25 18:24:20 2014 +0100

Lockless StrategyGetBuffer clock sweep hot path.

Looks good to me. I will commit/push the patch if there's no
objection.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Amit Kapila
Amit Kapila
amit.kapila16@gmail.com
In reply to: Tatsuo Ishii (#2)
Re: Fix a comment in feelist.c

On Mon, Jan 23, 2017 at 9:47 AM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

I've found a mistake in a comment of StrategyNotifyBgWriter
in freelist.c. bgwriterLatch was replaced by bgwprocno in
the following commit, but this is remained in the comment.

commit d72731a70450b5e7084991b9caa15cb58a2820df
Author: Andres Freund <andres@anarazel.de>
Date: Thu Dec 25 18:24:20 2014 +0100

Lockless StrategyGetBuffer clock sweep hot path.

Looks good to me.

+1.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Tatsuo Ishii
Tatsuo Ishii
t-ishii@sra.co.jp
In reply to: Tatsuo Ishii (#2)
Re: Fix a comment in feelist.c

I've found a mistake in a comment of StrategyNotifyBgWriter
in freelist.c. bgwriterLatch was replaced by bgwprocno in
the following commit, but this is remained in the comment.

commit d72731a70450b5e7084991b9caa15cb58a2820df
Author: Andres Freund <andres@anarazel.de>
Date: Thu Dec 25 18:24:20 2014 +0100

Lockless StrategyGetBuffer clock sweep hot path.

Looks good to me. I will commit/push the patch if there's no
objection.

Committed/pushed to all supported branches.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

← Back to Topics