Fix a comment in feelist.c

Started by Yugo Nagataalmost 10 years ago4 messageshackers
Beta feature

Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.

never appliedsuccessCI history

You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:

docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t35888
psql -h localhost -U postgres

Built from patchset v1 (message #1), July 28, 2026 at 02:38 PM.

Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:

git clone --branch t35888_1 https://github.com/hackorum-dev/postgres.git

In a checkout you already have, add the fork once:

git remote add hackorum https://github.com/hackorum-dev/postgres.git

then, for this patchset and every later one:

git fetch hackorum t35888_1 && git checkout t35888_1

Patchset v1 (message #1) is on t35888_1

Jump to latest
#1Yugo Nagata
nagata@sraoss.co.jp

Hi,

I've found a mistake in a comment of StrategyNotifyBgWriter
in freelist.c. bgwriterLatch was replaced by bgwprocno in
the following commit, but this is remained in the comment.

commit d72731a70450b5e7084991b9caa15cb58a2820df
Author: Andres Freund <andres@anarazel.de>
Date: Thu Dec 25 18:24:20 2014 +0100

Lockless StrategyGetBuffer clock sweep hot path.

Attached a patch.

--
Yugo Nagata <nagata@sraoss.co.jp>

Attachments:

t35888_1
fix_freelist_comment.patchtext/x-diff; name=fix_freelist_comment.patchDownload+2-2
#2Tatsuo Ishii
ishii@postgresql.org
In reply to: Yugo Nagata (#1)
Re: Fix a comment in feelist.c

I've found a mistake in a comment of StrategyNotifyBgWriter
in freelist.c. bgwriterLatch was replaced by bgwprocno in
the following commit, but this is remained in the comment.

commit d72731a70450b5e7084991b9caa15cb58a2820df
Author: Andres Freund <andres@anarazel.de>
Date: Thu Dec 25 18:24:20 2014 +0100

Lockless StrategyGetBuffer clock sweep hot path.

Looks good to me. I will commit/push the patch if there's no
objection.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#3Amit Kapila
amit.kapila16@gmail.com
In reply to: Tatsuo Ishii (#2)
Re: Fix a comment in feelist.c

On Mon, Jan 23, 2017 at 9:47 AM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

I've found a mistake in a comment of StrategyNotifyBgWriter
in freelist.c. bgwriterLatch was replaced by bgwprocno in
the following commit, but this is remained in the comment.

commit d72731a70450b5e7084991b9caa15cb58a2820df
Author: Andres Freund <andres@anarazel.de>
Date: Thu Dec 25 18:24:20 2014 +0100

Lockless StrategyGetBuffer clock sweep hot path.

Looks good to me.

+1.

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

#4Tatsuo Ishii
ishii@postgresql.org
In reply to: Tatsuo Ishii (#2)
Re: Fix a comment in feelist.c

I've found a mistake in a comment of StrategyNotifyBgWriter
in freelist.c. bgwriterLatch was replaced by bgwprocno in
the following commit, but this is remained in the comment.

commit d72731a70450b5e7084991b9caa15cb58a2820df
Author: Andres Freund <andres@anarazel.de>
Date: Thu Dec 25 18:24:20 2014 +0100

Lockless StrategyGetBuffer clock sweep hot path.

Looks good to me. I will commit/push the patch if there's no
objection.

Committed/pushed to all supported branches.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers