update portal-related memory context names and API
ISTM that some of the portal-related memory context naming is a bit
antiquated and at odds with current terminology. In this patch, I
propose to rename PortalMemory to TopPortalContext and rename
Portal->heap to Portal->portalContext, and then clean up some
surrounding APIs.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
0001-Update-portal-related-memory-context-names-and-API.patchtext/plain; charset=UTF-8; name=0001-Update-portal-related-memory-context-names-and-API.patch; x-mac-creator=0; x-mac-type=0Download+35-37
0002-Remove-PortalGetQueryDesc.patchtext/plain; charset=UTF-8; name=0002-Remove-PortalGetQueryDesc.patch; x-mac-creator=0; x-mac-type=0Download+5-11
On 12/19/2017 12:31 PM, Peter Eisentraut wrote:
ISTM that some of the portal-related memory context naming is a bit
antiquated and at odds with current terminology. In this patch, I
propose to rename PortalMemory to TopPortalContext and rename
Portal->heap to Portal->portalContext, and then clean up some
surrounding APIs.
Seems reasonable - 100% cosmetic AFAICT. Marking ready for committer.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Peter Eisentraut wrote:
Subject: [PATCH 1/2] Update portal-related memory context names and API
Rename PortalMemory to TopPortalContext, to avoid confusion with
PortalContext and align naming with similar top-level memory contexts.Rename PortalData's "heap" field to portalContext. The "heap" naming
seems quite antiquated and confusing. Also get rid of the
PortalGetHeapMemory() macro and access the field directly, which we do
for other portal fields, so this abstraction doesn't buy anything.
This one looks good to me. I was long confused by that "heap"
terminology.
Subject: [PATCH 2/2] Remove PortalGetQueryDesc()
After having gotten rid of PortalGetHeapMemory(), there seems little
reason to keep one Portal access macro around that offers no actual
abstraction and isn't consistently used anyway.
This macro does look quite pointless.
--
�lvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 1/8/18 15:30, Andrew Dunstan wrote:
On 12/19/2017 12:31 PM, Peter Eisentraut wrote:
ISTM that some of the portal-related memory context naming is a bit
antiquated and at odds with current terminology. In this patch, I
propose to rename PortalMemory to TopPortalContext and rename
Portal->heap to Portal->portalContext, and then clean up some
surrounding APIs.Seems reasonable - 100% cosmetic AFAICT. Marking ready for committer.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services