TODO item for broken \s with libedit seems fixed

Started by Patrick Kreckeralmost 8 years ago12 messages
#1Patrick Krecker
pkrecker@gmail.com

It appears this was fixed back in 2014 with 750c5ee. I propose for it
to be removed from the TODO list.

Thanks,
Patrick

#2Tatsuo Ishii
ishii@sraoss.co.jp
In reply to: Patrick Krecker (#1)
Re: TODO item for broken \s with libedit seems fixed

It appears this was fixed back in 2014 with 750c5ee. I propose for it
to be removed from the TODO list.

Yes, I confirmed it by using Ubuntu + libedit. I have not tested it on
Mac OS X yet though.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

#3Patrick Krecker
pkrecker@gmail.com
In reply to: Tatsuo Ishii (#2)
Re: TODO item for broken \s with libedit seems fixed

On Mon, Feb 26, 2018 at 4:54 PM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

It appears this was fixed back in 2014 with 750c5ee. I propose for it
to be removed from the TODO list.

Yes, I confirmed it by using Ubuntu + libedit. I have not tested it on
Mac OS X yet though.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

I tested on macOS 10.12.6.

Patrick

#4Tatsuo Ishii
ishii@sraoss.co.jp
In reply to: Patrick Krecker (#3)
Re: TODO item for broken \s with libedit seems fixed

On Mon, Feb 26, 2018 at 4:54 PM, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

It appears this was fixed back in 2014 with 750c5ee. I propose for it
to be removed from the TODO list.

Yes, I confirmed it by using Ubuntu + libedit. I have not tested it on
Mac OS X yet though.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

I tested on macOS 10.12.6.

Ok, let's mark it as "Done.", (rather than removing it) if there's no
objection.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

#5Tom Lane
tgl@sss.pgh.pa.us
In reply to: Tatsuo Ishii (#4)
Re: TODO item for broken \s with libedit seems fixed

Tatsuo Ishii <ishii@sraoss.co.jp> writes:

Ok, let's mark it as "Done.", (rather than removing it) if there's no
objection.

I think that, back when we were actively maintaining the TODO list,
the idea was that items got marked as "Done" when committed and then
removed from the list after the fix was released. In this case, since
the fix went out years ago, we might as well just remove the entry
immediately.

regards, tom lane

#6Tatsuo Ishii
ishii@sraoss.co.jp
In reply to: Tom Lane (#5)
Re: TODO item for broken \s with libedit seems fixed

I think that, back when we were actively maintaining the TODO list,
the idea was that items got marked as "Done" when committed and then
removed from the list after the fix was released. In this case, since
the fix went out years ago, we might as well just remove the entry
immediately.

I would prefer to mark it done then remove the item just for leaving
an editing history.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

#7Tom Lane
tgl@sss.pgh.pa.us
In reply to: Tatsuo Ishii (#6)
Re: TODO item for broken \s with libedit seems fixed

Tatsuo Ishii <ishii@sraoss.co.jp> writes:

I would prefer to mark it done then remove the item just for leaving
an editing history.

Sure, although leaving a commit message with a pointer to the fix in git
would document this better.

regards, tom lane

#8Tatsuo Ishii
ishii@sraoss.co.jp
In reply to: Tom Lane (#7)
Re: TODO item for broken \s with libedit seems fixed

Sure, although leaving a commit message with a pointer to the fix in git
would document this better.

Right. We should always do that.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

#9Tatsuo Ishii
ishii@sraoss.co.jp
In reply to: Tatsuo Ishii (#8)
Re: TODO item for broken \s with libedit seems fixed

Patrick,

Sure, although leaving a commit message with a pointer to the fix in git
would document this better.

Right. We should always do that.

Would you like to do this yourself? Or shall I do this?

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

#10Tom Lane
tgl@sss.pgh.pa.us
In reply to: Tatsuo Ishii (#9)
Re: TODO item for broken \s with libedit seems fixed

Tatsuo Ishii <ishii@sraoss.co.jp> writes:

Would you like to do this yourself? Or shall I do this?

Go ahead, I have a bunch of other stuff to do ...

regards, tom lane

#11Patrick Krecker
pkrecker@gmail.com
In reply to: Tom Lane (#10)
Re: TODO item for broken \s with libedit seems fixed

On Feb 27, 2018, at 06:25, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Tatsuo Ishii <ishii@sraoss.co.jp> writes:

Would you like to do this yourself? Or shall I do this?

Go ahead, I have a bunch of other stuff to do ...

regards, tom lane

I don’t think I have permission to edit the page, otherwise I would be happy to.

Thanks,
Patrick

#12Tatsuo Ishii
ishii@sraoss.co.jp
In reply to: Tom Lane (#10)
Re: TODO item for broken \s with libedit seems fixed

Tatsuo Ishii <ishii@sraoss.co.jp> writes:

Would you like to do this yourself? Or shall I do this?

Go ahead, I have a bunch of other stuff to do ...

Done. Once my editing is confirmed ok, I will delete the item.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp