on or true

On Sun, Dec 2, 2018 at 1:25 AM Tatsuo Ishii <ishii@sraoss.co.jp> wrote:

In the documentation of ssl_passphrase_command_supports_reload:

configuration reload if a key file needs a passphrase. If this
parameter is false (the default), then
:
:
running. Setting this parameter to true might be appropriate if the
passphrase is obtained from a file, for example.

I thought we prefer "on/off" rather than "true/false" for boolean
parameter values in postgresql.conf. Should we change them to "on/off"?

+1 for on/off

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

--
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

I thought we prefer "on/off" rather than "true/false" for boolean
parameter values in postgresql.conf. Should we change them to "on/off"?

+1 for on/off

I found a few more
places where true/false is used other than
ssl_passphrase_command_supports_reload in config.sgml.
Attached is a patch to fix them in config.sgml.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

I found a few more
places where true/false is used other than
ssl_passphrase_command_supports_reload in config.sgml.
Attached is a patch to fix them in config.sgml.

I will commit this to the master branch if there's no objection.
Since this is an enhancement, not a bug fix, I think no back patching
is necessary.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp

I found a few more
places where true/false is used other than
ssl_passphrase_command_supports_reload in config.sgml.
Attached is a patch to fix them in config.sgml.

I will commit this to the master branch if there's no objection.
Since this is an enhancement, not a bug fix, I think no back patching
is necessary.

Done.

Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp