unsafe_tests module

Started by Andrew Dunstanalmost 3 years ago3 messages
#1Andrew Dunstan
andrew@dunslane.net

Given its nature and purpose as a module we don't want to run against an
installed instance, shouldn't src/test/modules/unsafe_tests have
NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build?

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

#2Andres Freund
andres@anarazel.de
In reply to: Andrew Dunstan (#1)
Re: unsafe_tests module

Hi,

On 2023-02-22 06:47:34 -0500, Andrew Dunstan wrote:

Given its nature and purpose as a module we don't want to run against an
installed instance, shouldn't src/test/modules/unsafe_tests have
NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build?

Seems like a good idea to me.

Greetings,

Andres Freund

#3Andrew Dunstan
andrew@dunslane.net
In reply to: Andres Freund (#2)
Re: unsafe_tests module

On 2023-03-11 Sa 19:12, Andres Freund wrote:

Hi,

On 2023-02-22 06:47:34 -0500, Andrew Dunstan wrote:

Given its nature and purpose as a module we don't want to run against an
installed instance, shouldn't src/test/modules/unsafe_tests have
NO_INSTALLCHECK=1 in its Makefile and runningcheck:false in its meson.build?

Seems like a good idea to me.

Thanks, done.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com