pg_bsd_indent vs vpath

Started by Andrew Dunstanalmost 3 years ago3 messages
#1Andrew Dunstan
andrew@dunslane.net

Looks like we need a little magic to allow pg_bsd_indent to be part of a
vpath build:

<https://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=fairywren&amp;dt=2023-03-23%2014%3A21%3A08&amp;stg=module-pg_bsd_indent-check&gt;

It succeeded if I added this to the Makefile:

CFLAGS += -I$(srcdir)

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com

#2Tom Lane
tgl@sss.pgh.pa.us
In reply to: Andrew Dunstan (#1)
Re: pg_bsd_indent vs vpath

Andrew Dunstan <andrew@dunslane.net> writes:

Looks like we need a little magic to allow pg_bsd_indent to be part of a
vpath build:

Yeah, I think I fixed that at dccef0f2f, but fairywren hasn't run since.
(I'd thought that it was some weird Msys-ism, but if you say it's VPATH
then all is clear, other than why we didn't notice already.)

regards, tom lane

#3Andrew Dunstan
andrew@dunslane.net
In reply to: Tom Lane (#2)
Re: pg_bsd_indent vs vpath

On 2023-03-23 Th 16:46, Tom Lane wrote:

Andrew Dunstan<andrew@dunslane.net> writes:

Looks like we need a little magic to allow pg_bsd_indent to be part of a
vpath build:

Yeah, I think I fixed that at dccef0f2f, but fairywren hasn't run since.
(I'd thought that it was some weird Msys-ism, but if you say it's VPATH
then all is clear, other than why we didn't notice already.)

The code to pick up src/tools isn't in released code yet, and I just
updated fairywren from git to test some other code.

Anyway, it's all good, fairywren is now building this happily.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com