Minor document typo
Hackorum builds and tests every patch posted to the lists, not only commitfest submissions. This is Hackorum's own CI rather than the PostgreSQL project's, and it is still under testing - please report anything that looks wrong.
You can run a PostgreSQL built from this patch straight from Docker, with no checkout and no build:
docker run --rm -p 5432:5432 ghcr.io/hackorum-dev/postgres-patch:t49509psql -h localhost -U postgresBuilt from patchset v1 (message #1), October 25, 2026 at 03:28 AM.
Every patchset is also pushed to a branch of our PostgreSQL fork, so you can check out the same tree CI built. Without a PostgreSQL checkout:
git clone --branch t49509_1 https://github.com/hackorum-dev/postgres.gitIn a checkout you already have, add the fork once:
git remote add hackorum https://github.com/hackorum-dev/postgres.gitthen, for this patchset and every later one:
git fetch hackorum t49509_1 && git checkout t49509_1Patchset v1 (message #1) is on t49509_1
Hi,
doc/src/sgml/monitoring.sgml seems to have a minor typo:
In pg_stat_database_conflicts section (around line 3621) we have:
<para>
Number of uses of logical slots in this database that have been
canceled due to old snapshots or too low a <xref linkend="guc-wal-level"/>
on the primary
</para></entry>
I think "too low a" should be "too low" ('a' is not
necessary). Attached is the patch.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
On Tue, 23 Apr 2024 at 23:17, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
Number of uses of logical slots in this database that have been
canceled due to old snapshots or too low a <xref linkend="guc-wal-level"/>
on the primaryI think "too low a" should be "too low" ('a' is not
necessary). Attached is the patch.
The existing text looks fine to me. The other form would use "of a"
and become "too low of a wal_level on the primary".
"too low wal_level on the primary" sounds wrong to my native
English-speaking ear.
There's some discussion in [1]https://www.reddit.com/r/grammar/comments/qr9z6e/i_need_help_with_sothat_adj_of_a_sing_noun/?ref=share&ref_source=link that might be of interest to you.
David
I think "too low a" should be "too low" ('a' is not
necessary). Attached is the patch.The existing text looks fine to me. The other form would use "of a"
and become "too low of a wal_level on the primary"."too low wal_level on the primary" sounds wrong to my native
English-speaking ear.There's some discussion in [1] that might be of interest to you.
David
Thank you for the explanation. English is difficult :-)
Just out of a curiosity, is it possible to say "low a wal_level on the
primary"? (just "too" is removed)
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
On Wed, 24 Apr 2024 at 00:11, Tatsuo Ishii <ishii@sraoss.co.jp> wrote:
Just out of a curiosity, is it possible to say "low a wal_level on the
primary"? (just "too" is removed)
Prefixing the adjective with "too" means it's beyond the acceptable
range. "This coffee is too hot".
https://dictionary.cambridge.org/grammar/british-grammar/too
David