Fix a comment on PQcancelErrorMessage
Hi,
Attached is a small patch to fix a comment on PQcancelErrorMessage.
It was accidentally "Get the socket of the cancel connection."
I rewrote it to "Returns the error message most recently generated
by an operation on the cancel connection."
Regards,
Yugo Nagata
--
Yugo NAGATA <nagata@sraoss.co.jp>
Attachments:
fix_PQcancelErrorMessage_comments.patchtext/x-diff; name=fix_PQcancelErrorMessage_comments.patchDownload+2-1
Hi,
Attached is a small patch to fix a comment on PQcancelErrorMessage.
It was accidentally "Get the socket of the cancel connection."
I rewrote it to "Returns the error message most recently generated
by an operation on the cancel connection."
Good catch. The proposed message matches the PQCancelErrorMessage()
documentation and looks good.
Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp
Import Notes
Reply to msg id not found: 20240704134638.355ad44a445fa1e764a220cd@sranhm.sraoss.co.jp.sranhmReference msg id not found: 20240704134638.355ad44a445fa1e764a220cd@sranhm.sraoss.co.jp.sranhm | Resolved by subject fallback
On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA <nagata@sraoss.co.jp> wrote:
Attached is a small patch to fix a comment on PQcancelErrorMessage.
Oops, copy paste mistake on my part I guess. New comment LGTM
On Thu, 4 Jul 2024 11:06:03 +0200
Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA <nagata@sraoss.co.jp> wrote:
Attached is a small patch to fix a comment on PQcancelErrorMessage.
Oops, copy paste mistake on my part I guess. New comment LGTM
Thank you for your comments.
I made a trivial change that fixes the line break position in keeping with
the surrounding comments.
Regards,
Yugo Nagata
--
Yugo NAGATA <nagata@sraoss.co.jp>
Attachments:
v2_fix_PQcancelErrorMessage_comment.patchtext/x-diff; name=v2_fix_PQcancelErrorMessage_comment.patchDownload+2-1
Import Notes
Reply to msg id not found: CAGECzQQxDFtrMpBoQsj0JE45mKF55U6cyJXnjR6hOcRZkfgaUw@mail.gmail.com.sranhm
On 2024-Jul-04, Yugo NAGATA wrote:
On Thu, 4 Jul 2024 11:06:03 +0200
Jelte Fennema-Nio <postgres@jeltef.nl> wrote:On Thu, 4 Jul 2024 at 06:46, Yugo NAGATA <nagata@sraoss.co.jp> wrote:
Attached is a small patch to fix a comment on PQcancelErrorMessage.
Oops, copy paste mistake on my part I guess. New comment LGTM
Thank you for your comments.
I made a trivial change that fixes the line break position in keeping with
the surrounding comments.
Ugh, mea culpa for failing to notice -- thank you, pushed.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Learn about compilers. Then everything looks like either a compiler or
a database, and now you have two problems but one of them is fun."
https://twitter.com/thingskatedid/status/1456027786158776329