ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated

Started by Yasirover 1 year ago7 messages
#1Yasir
yasir.hussain.shah@gmail.com

Hi Hackers,

Recently, I compiled PG17 on the windows. Till PG16 "ActiveState Perl", as
instructed in the documentation
<https://www.postgresql.org/docs/16/install-windows-full.html#INSTALL-WINDOWS-FULL-REQUIREMENTS&gt;,
was being used successfully on the Windows 10/11 to compile PG.
However, it looks like that "ActiveState Perl" is not valid anymore to
compile PG17 on Windows 10/11 but documentation
<https://www.postgresql.org/docs/17/installation-platform-notes.html#WINDOWS-REQUIREMENTS&gt;
still
suggests it. Therefore, I think documentation needs to be updated.
Moreover, I had to install "strawberry's perl" in order to compile PG17 on
Windows 10/11. Please check out the thread "errors building on windows
using meson
</messages/by-id/CADK3HHLQ1MNmfXqEvQi36D_MQrheOZPcXv2H3s6otMbSmfwjzg@mail.gmail.com&gt;&quot;
highlighting the issue.

Regards...

Yasir Hussain
Bitnine Global Inc.

#2Andrew Dunstan
andrew@dunslane.net
In reply to: Yasir (#1)
Re: ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated

On 2024-07-16 Tu 7:46 AM, Yasir wrote:

Hi Hackers,

Recently, I compiled PG17 on the windows. Till PG16 "ActiveState
Perl", as instructed in the documentation
<https://www.postgresql.org/docs/16/install-windows-full.html#INSTALL-WINDOWS-FULL-REQUIREMENTS&gt;,
was being used successfully on the Windows 10/11 to compile PG.
However, it looks like that "ActiveState Perl" is not valid anymore to
compile PG17 on Windows 10/11 but documentation
<https://www.postgresql.org/docs/17/installation-platform-notes.html#WINDOWS-REQUIREMENTS&gt; still
suggests it. Therefore, I think documentation needs to be updated.
Moreover, I had to install "strawberry's perl" in order to compile
PG17 on Windows 10/11. Please check out the thread "errors building on
windows using meson
</messages/by-id/CADK3HHLQ1MNmfXqEvQi36D_MQrheOZPcXv2H3s6otMbSmfwjzg@mail.gmail.com&gt;&quot;
highlighting the issue.

See /messages/by-id/4acddcd4-1c08-44e7-ba60-cab1022599e3@dunslane.net

I agree we should fix the docco.

cheers

andrew

--

Andrew Dunstan
EDB:https://www.enterprisedb.com

#3Bruce Momjian
bruce@momjian.us
In reply to: Andrew Dunstan (#2)
1 attachment(s)
Re: ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated

On Tue, Jul 16, 2024 at 08:23:11AM -0400, Andrew Dunstan wrote:

On 2024-07-16 Tu 7:46 AM, Yasir wrote:

Hi Hackers, 

Recently, I compiled PG17 on the windows. Till PG16 "ActiveState Perl", as
instructed in the documentation, was being used successfully on the Windows
10/11 to compile PG. 
However, it looks like that "ActiveState Perl" is not valid anymore to
compile PG17 on Windows 10/11 but documentation still suggests it.
Therefore, I think documentation needs to be updated.
Moreover, I had to install "strawberry's perl" in order to compile PG17 on
Windows 10/11. Please check out the thread "errors building on windows
using meson" highlighting the issue. 

See  /messages/by-id/4acddcd4-1c08-44e7-ba60-cab1022599e3@dunslane.net

I agree we should fix the docco.

I have written the attached patch to make these changes.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"

Attachments:

activestate.difftext/x-diff; charset=us-asciiDownload
diff --git a/doc/src/sgml/installation.sgml b/doc/src/sgml/installation.sgml
index 3a491b59896..0e16bb01d85 100644
--- a/doc/src/sgml/installation.sgml
+++ b/doc/src/sgml/installation.sgml
@@ -3809,14 +3809,12 @@ make: *** [postgres] Error 1
 
      <variablelist>
       <varlistentry>
-       <term><productname>ActiveState Perl</productname></term>
+       <term><productname>Strawberry Perl</productname></term>
        <listitem><para>
-        ActiveState Perl is required to run the build generation scripts. MinGW
+        Strawberry Perl is required to run the build generation scripts. MinGW
         or Cygwin Perl will not work. It must also be present in the PATH.
         Binaries can be downloaded from
-        <ulink url="https://www.activestate.com"></ulink>
-        (Note: version 5.14 or later is required,
-        the free Standard Distribution is sufficient).
+        <ulink url="https://strawberryperl.com"></ulink>.
        </para></listitem>
       </varlistentry>
 
@@ -3868,10 +3866,9 @@ make: *** [postgres] Error 1
 
      <variablelist>
       <varlistentry>
-       <term><productname>ActiveState Tcl</productname></term>
+       <term><productname>Magicsplat Tcl</productname></term>
        <listitem><para>
-        Required for building <application>PL/Tcl</application> (Note: version
-        8.4 is required, the free Standard Distribution is sufficient).
+        Required for building <application>PL/Tcl</application>.
        </para></listitem>
       </varlistentry>
 
#4Umar Hayat
postgresql.wizard@gmail.com
In reply to: Bruce Momjian (#3)
Re: ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated

Hi Bruce,
Patch looks good. In my opinion patch should be committed as more and
more people who are trying to build PG 17 on Windows are facing
similar issues. Latest issue was reported yesterday [0]/messages/by-id/CA+OCxozXN=GFPWU8vBjG6ch=i2q46FrQbTMjpsERGaSXQj-+tQ@mail.gmail.com.

Regards
Umar Hayat

[0]: /messages/by-id/CA+OCxozXN=GFPWU8vBjG6ch=i2q46FrQbTMjpsERGaSXQj-+tQ@mail.gmail.com

Umar Hayat

Show quoted text

On Thu, 17 Oct 2024 at 07:35, Bruce Momjian <bruce@momjian.us> wrote:

On Tue, Jul 16, 2024 at 08:23:11AM -0400, Andrew Dunstan wrote:

On 2024-07-16 Tu 7:46 AM, Yasir wrote:

Hi Hackers,

Recently, I compiled PG17 on the windows. Till PG16 "ActiveState Perl", as
instructed in the documentation, was being used successfully on the Windows
10/11 to compile PG.
However, it looks like that "ActiveState Perl" is not valid anymore to
compile PG17 on Windows 10/11 but documentation still suggests it.
Therefore, I think documentation needs to be updated.
Moreover, I had to install "strawberry's perl" in order to compile PG17 on
Windows 10/11. Please check out the thread "errors building on windows
using meson" highlighting the issue.

See /messages/by-id/4acddcd4-1c08-44e7-ba60-cab1022599e3@dunslane.net

I agree we should fix the docco.

I have written the attached patch to make these changes.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"

#5Daniel Gustafsson
daniel@yesql.se
In reply to: Bruce Momjian (#3)
Re: ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated

On 17 Oct 2024, at 00:35, Bruce Momjian <bruce@momjian.us> wrote:
On Tue, Jul 16, 2024 at 08:23:11AM -0400, Andrew Dunstan wrote:

See /messages/by-id/4acddcd4-1c08-44e7-ba60-cab1022599e3@dunslane.net

I agree we should fix the docco.

I have written the attached patch to make these changes.

+1 for applying backpatched to at least 17 but possibly further down judging by
the linked threads.

--
Daniel Gustafsson

#6Michael Paquier
michael@paquier.xyz
In reply to: Daniel Gustafsson (#5)
Re: ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated

On Mon, Oct 28, 2024 at 01:07:16PM +0100, Daniel Gustafsson wrote:

+1 for applying backpatched to at least 17 but possibly further down judging by
the linked threads.

When using ActiveState perl, being able to call `perl` from a PATH
requires one to register into a central service related to the company
that provides these binaries. Still recommending it even on stable
branches makes me really uneasy.
--
Michael

#7Bruce Momjian
bruce@momjian.us
In reply to: Daniel Gustafsson (#5)
Re: ActiveState Perl is not valid anymore to build PG17 on the Windows 10/11 platforms, So Documentation still suggesting it should be updated

On Mon, Oct 28, 2024 at 01:07:16PM +0100, Daniel Gustafsson wrote:

On 17 Oct 2024, at 00:35, Bruce Momjian <bruce@momjian.us> wrote:
On Tue, Jul 16, 2024 at 08:23:11AM -0400, Andrew Dunstan wrote:

See /messages/by-id/4acddcd4-1c08-44e7-ba60-cab1022599e3@dunslane.net

I agree we should fix the docco.

I have written the attached patch to make these changes.

+1 for applying backpatched to at least 17 but possibly further down judging by
the linked threads.

I added a URL for Magicsplat Tcl and backpatched to 12.

--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EDB https://enterprisedb.com

When a patient asks the doctor, "Am I going to die?", he means
"Am I going to die soon?"