jsonlog cursor_position type is wrong.

Started by nuko yokohamaover 3 years ago6 messagesdocs
Jump to latest
#1nuko yokohama
nuko.yokohama@gmail.com

Hi.

PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
"Type" in cursor_position should be "number", not "Sting".
https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-KEYS-VALUES

#2Tatsuo Ishii
t-ishii@sra.co.jp
In reply to: nuko yokohama (#1)
Re: jsonlog cursor_position type is wrong.

Hi.

PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
"Type" in cursor_position should be "number", not "Sting".
https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-KEYS-VALUES

Yeah, that's a typo. Patch attached.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

Attachments:

config.patchtext/x-patch; charset=us-asciiDownload+1-1
#3Tom Lane
tgl@sss.pgh.pa.us
In reply to: Tatsuo Ishii (#2)
Re: jsonlog cursor_position type is wrong.

Tatsuo Ishii <ishii@sraoss.co.jp> writes:

PostgreSQL document In "Table 20.3. Keys and Values of JSON Log Entries",
"Type" in cursor_position should be "number", not "Sting".
https://www.postgresql.org/docs/current/runtime-config-logging.html#RUNTIME-CONFIG-LOGGING-JSONLOG-KEYS-VALUES

Yeah, that's a typo. Patch attached.

Shouldn't it be "integer"?

regards, tom lane

#4Michael Paquier
michael@paquier.xyz
In reply to: Tom Lane (#3)
Re: jsonlog cursor_position type is wrong.

On Mon, Oct 24, 2022 at 12:53:26AM -0400, Tom Lane wrote:

Tatsuo Ishii <ishii@sraoss.co.jp> writes:

Yeah, that's a typo. Patch attached.

Thanks, that's wrong :/

Shouldn't it be "integer"?

When it comes down to the data types of a JSON object, these are
referred as "number", as these can be either integers or floating
points. See:
https://www.w3schools.com/js/js_json_datatypes.asp
--
Michael

#5Michael Paquier
michael@paquier.xyz
In reply to: Michael Paquier (#4)
Re: jsonlog cursor_position type is wrong.

On Mon, Oct 24, 2022 at 02:04:48PM +0900, Michael Paquier wrote:

Thanks, that's wrong :/

Anyway, this one is on me, so applied. Thanks for the patch and the
report!
--
Michael

#6Tatsuo Ishii
t-ishii@sra.co.jp
In reply to: Michael Paquier (#5)
Re: jsonlog cursor_position type is wrong.

On Mon, Oct 24, 2022 at 02:04:48PM +0900, Michael Paquier wrote:

Thanks, that's wrong :/

Anyway, this one is on me, so applied. Thanks for the patch and the
report!

Thank you!
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp